Re: [PR] Update Google Ads API version from v14 to v15 [airflow]

2023-11-03 Thread via GitHub
potiuk commented on PR #35295: URL: https://github.com/apache/airflow/pull/35295#issuecomment-1792793937 Looks good and passed enough tests so that we should be able to safely merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Update Google Ads API version from v14 to v15 [airflow]

2023-11-03 Thread via GitHub
potiuk merged PR #35295: URL: https://github.com/apache/airflow/pull/35295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Update Google Ads API version from v14 to v15 [airflow]

2023-11-02 Thread via GitHub
MaksYermak commented on code in PR #35295: URL: https://github.com/apache/airflow/pull/35295#discussion_r1380178705 ## airflow/providers/google/ads/hooks/ads.py: ## @@ -31,9 +31,9 @@ from airflow.providers.google.common.hooks.base_google import get_field if TYPE_CHECKING: -

Re: [PR] Update Google Ads API version from v14 to v15 [airflow]

2023-10-31 Thread via GitHub
eladkal commented on code in PR #35295: URL: https://github.com/apache/airflow/pull/35295#discussion_r1377526195 ## airflow/providers/google/ads/hooks/ads.py: ## @@ -31,9 +31,9 @@ from airflow.providers.google.common.hooks.base_google import get_field if TYPE_CHECKING: -

[PR] Update Google Ads API version from v14 to v15 [airflow]

2023-10-31 Thread via GitHub
MaksYermak opened a new pull request, #35295: URL: https://github.com/apache/airflow/pull/35295 In this PR I have updated Google Ads API version from v14 to v15 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com