ap-- opened a new pull request, #37524:
URL: https://github.com/apache/airflow/pull/37524
closes: #37067
related: #36546
This PR adjusts the `airflow.io.path.ObjectStoragePath` implementation to
support the new `universal_pathlib>=0.2.1`.
Functionality shou
boring-cyborg[bot] commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1951428692
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
ap-- commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1951429536
Also, if a core developer can point me to the easiest way to run the
relevant parts of the test suite on an M2 mac that would be wonderful ❤️
--
This is an automated message from the Ap
potiuk commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1951441014
Cool.
> Also, if a core developer can point me to the easiest way to run the
relevant parts of the test suite on an M2 mac that would be wonderful ❤️
This should be rather e
potiuk commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1951441178
(I approved/run) the tests BTW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
potiuk commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1951441555
Also installing `pre-commit` and running `pre-commit install` is a good idea
- this way all static checks will be locally run for you before you commit
anything giving you a quick feedba
uranusjr commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1494021929
##
tests/providers/common/io/xcom/test_backend.py:
##
@@ -181,7 +182,7 @@ def test_value_storage(self, task_instance, session):
run_id=task_instance.run
uranusjr commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1494022774
##
tests/io/test_path.py:
##
@@ -60,34 +89,39 @@ def get_fs_no_storage_options(_: str):
class TestFs:
def setup_class(self):
self._store_cache = _STOR
uranusjr commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1494023527
##
airflow/providers/common/io/xcom/backend.py:
##
@@ -152,7 +152,7 @@ def deserialize_value(
try:
p = ObjectStoragePath(path) / XComObjectSt
bolkedebruin commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1494298461
##
tests/io/test_path.py:
##
@@ -60,34 +89,39 @@ def get_fs_no_storage_options(_: str):
class TestFs:
def setup_class(self):
self._store_cache = _
bolkedebruin commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1494298461
##
tests/io/test_path.py:
##
@@ -60,34 +89,39 @@ def get_fs_no_storage_options(_: str):
class TestFs:
def setup_class(self):
self._store_cache = _
ap-- commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1495054871
##
tests/providers/common/io/xcom/test_backend.py:
##
@@ -181,7 +182,7 @@ def test_value_storage(self, task_instance, session):
run_id=task_instance.run_id,
ap-- commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1495055053
##
tests/io/test_path.py:
##
@@ -60,34 +89,39 @@ def get_fs_no_storage_options(_: str):
class TestFs:
def setup_class(self):
self._store_cache = _STORE_CA
ap-- commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1495056345
##
airflow/providers/common/io/xcom/backend.py:
##
@@ -152,7 +152,7 @@ def deserialize_value(
try:
p = ObjectStoragePath(path) / XComObjectStoreB
ap-- commented on code in PR #37524:
URL: https://github.com/apache/airflow/pull/37524#discussion_r1495056522
##
tests/io/test_path.py:
##
@@ -227,16 +271,13 @@ def test_move_remote(self):
_to.unlink()
def test_copy_remote_remote(self):
-# foo = xxx added
bolkedebruin merged PR #37524:
URL: https://github.com/apache/airflow/pull/37524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@air
boring-cyborg[bot] commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1953848153
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
bolkedebruin commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1953851699
Oops, I think I might have missed a failing test / regression. I'll take a
look
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ephraimbuddy commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1953943533
There are lots of conflicts while cherrypicking this to 2.8.2. I will be
moving it to 2.9.0 except anyone want to try the cherry-picking? cc
@bolkedebruin @potiuk
--
This is an
bolkedebruin commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1953958176
Why? That seems weird @ephraimbuddy ? (I.e. the conflicts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
potiuk commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1953967903
> Awesome! Thanks for this @ap--
Fantastic :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
potiuk commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1953973271
> Why? That seems weird @ephraimbuddy ? (I.e. the conflicts). It's quite
isolated on its own and no I think this should be in 2.8.2.
Because there are other committs that will nee
bolkedebruin commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1953976544
Ah yes. Well up to you. Seems nice to have this in 2.8.2 but its fine in 2.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
potiuk commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1953983388
Those are `io` related changes that are not cherry-picked to v2-8-test -
@ephraimbuddy you might try but IMHO it's a bit too risky (and also some code
there explicitly mentions >= 2.9.0
ephraimbuddy commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1954006696
> Those are `io` related changes that are not cherry-picked to v2-8-test -
@ephraimbuddy you might try but IMHO it's a bit too risky (and also some code
there explicitly mentions >
bolkedebruin commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1954023742
Great! Even better because I think there is a regression now @ap-- . The
modules are eagerly loaded now ie:
```
o = ObjectStoragePath("s3://xxx")
```
Will now lo
ap-- commented on PR #37524:
URL: https://github.com/apache/airflow/pull/37524#issuecomment-1955041434
> Great! Even better because I think there is a regression now @ap-- . The
modules are eagerly loaded now ie:
>
> ```
> o = ObjectStoragePath("s3://xxx")
> ```
>
> Will
27 matches
Mail list logo
