vincbeck commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1841298814
Congrats @dashton90 , thanks to your PR, the system test is now succeeding,
see dashboard
[here](https://aws-mwaa.github.io/#/open-source/system-tests/dashboard.html)
--
This is an
vincbeck merged PR #35839:
URL: https://github.com/apache/airflow/pull/35839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
vincbeck commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1414690967
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -50,11 +50,14 @@ def get_latest_ami_id():
# on how they name the new images. This page should have A
dashton90 commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1414672360
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -50,11 +50,14 @@ def get_latest_ami_id():
# on how they name the new images. This page should have
o-nikolas commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1414321536
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -50,11 +50,14 @@ def get_latest_ami_id():
# on how they name the new images. This page should have
o-nikolas commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1414320882
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -149,13 +155,16 @@ def parse_response(instance_ids: list):
reboot_instance = EC2RebootInstanceOperat
vincbeck commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1412170813
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -50,11 +50,14 @@ def get_latest_ami_id():
# on how they name the new images. This page should have A
ferruzzi commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1411501913
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -50,11 +50,14 @@ def get_latest_ami_id():
# on how they name the new images. This page should have A
dashton90 commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1835253644
Moved everything out of the codeblock in
https://github.com/apache/airflow/pull/35839/commits/b8e65688f4d6db438465c82d2146333d2e117e71
--
This is an automated message from the Apach
dashton90 commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1411493992
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -50,11 +50,14 @@ def get_latest_ami_id():
# on how they name the new images. This page should have
dashton90 commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1411493466
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -149,13 +155,16 @@ def parse_response(instance_ids: list):
reboot_instance = EC2RebootInstanceOperat
o-nikolas commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1411449834
##
tests/system/providers/amazon/aws/example_ec2.py:
##
@@ -149,13 +155,16 @@ def parse_response(instance_ids: list):
reboot_instance = EC2RebootInstanceOperat
syedahsn commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1834911177
+1 to moving `wait_for_completion` and `max_retries` out of the codeblock,
but otherwise LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message,
ferruzzi commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1834871835
I merged main into the branch and that got the CI tests to pass. :rocket:
The only other thing I'd like to see is move the wait_for_completion and the
max_retries out of the co
dashton90 commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1831048132
Done in
https://github.com/apache/airflow/pull/35839/commits/00e06ce86601f8c2c54b9e16ccb6177477c76b7a
--
This is an automated message from the Apache Git Service.
To respond to the
ferruzzi commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1830826548
Alright, I dialed it in. It passed with `max_retries` set to 75 and fails
at 60, so let's go with 75 for now. We can bump it later as needed, but that
seems like a reasonable start
ferruzzi commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1828826424
Alright, I think I got my laptop's docker issue figured out and I ran the
system, test as you have it here, but with `max_attempts=999,` added to
hibernate_instance and it passes! it
ferruzzi commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1828654412
In response to my last comment, it looks like the consensus is to get this
sorted out, then we (I) can split it into two tests and just run them in
parallel. We're fine with the run
ferruzzi commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1828540927
I am actually poking at it right now. When I ran it with the
`wait_for_completion` it ended up with a waiter timeout, so I bumped
max_attempts to 999 just to see if that solved it.
dashton90 commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1828524090
@ferruzzi
Tried this example myself against the latest version of the providers
package and it looks like there are a few things going on.
1. [Instances cannot be hibernated
dashton90 commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1826082872
Huh, it looks like boto [fails the terminate waiter if the instance is in
the stopping
state](https://github.com/boto/botocore/blob/81c0e57059de3ed7a56bf183e322a83f7a9e80ec/botocore/d
ferruzzi commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1826050859
Alright. progress! I ran the proposed changes and it failed, but it's
getting much further. Here's the current state:
```
INFO
airflow.task.operators.airflow.provide
ferruzzi commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1826009643
>Amazon will default to using an Amazon managed key to encrypt the volume if
you don't specify one.
AH! I misunderstood, I thought you meant "Amazon" meaning my team
specificall
dashton90 commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1825998596
I added you as a collaborator to my fork so you should be free to push any
changes you need. But I can make the changes myself tonight or tomorrow if you
don't get around to it.
ferruzzi commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1825971688
At a glance, it looks right. As mentioned, we'll need to adjust it to
accept a KMS key to encrypt the EBS volume. Github makes it a bit of a pain to
collaborate on a PR like this; it
dashton90 opened a new pull request, #35839:
URL: https://github.com/apache/airflow/pull/35839
A bug was introduced in the ec2_example DAG when adding the
`EC2HibernateInstanceOperator`. This PR updates the configuration of the
example to create an instance which supports hibernation.
dashton90 commented on PR #35839:
URL: https://github.com/apache/airflow/pull/35839#issuecomment-1825802104
@ferruzzi tagging you since you flagged the bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
27 matches
Mail list logo
