potiuk commented on code in PR #35085:
URL: https://github.com/apache/airflow/pull/35085#discussion_r1411379983
##
airflow/auth/managers/fab/security_manager/override.py:
##
@@ -1432,23 +1430,14 @@ def get_oauth_user_info(self, provider, resp):
"last_name": data
potiuk commented on code in PR #35085:
URL: https://github.com/apache/airflow/pull/35085#discussion_r1410905233
##
airflow/auth/managers/fab/security_manager/override.py:
##
@@ -1432,23 +1430,14 @@ def get_oauth_user_info(self, provider, resp):
"last_name": data
potiuk commented on code in PR #35085:
URL: https://github.com/apache/airflow/pull/35085#discussion_r1410905233
##
airflow/auth/managers/fab/security_manager/override.py:
##
@@ -1432,23 +1430,14 @@ def get_oauth_user_info(self, provider, resp):
"last_name": data
hterik commented on code in PR #35085:
URL: https://github.com/apache/airflow/pull/35085#discussion_r1410850196
##
airflow/auth/managers/fab/security_manager/override.py:
##
@@ -1432,23 +1430,14 @@ def get_oauth_user_info(self, provider, resp):
"last_name": data
jens-scheffler-bosch commented on PR #35085:
URL: https://github.com/apache/airflow/pull/35085#issuecomment-1773898293
2.8.0 is also okay. We have (for our setup) no dependency. No pressure from
my side.
--
This is an automated message from the Apache Git Service.
To respond to the messag
potiuk commented on PR #35085:
URL: https://github.com/apache/airflow/pull/35085#issuecomment-1773846413
Well. Just changed it to 2.8.0. It won't make it to 2.7.3 because we have
quite heavy refactor for AIP-58 and we won't be able to cherry-pick this change
cleanly. Sorry for that :(
--
jens-scheffler-bosch commented on PR #35085:
URL: https://github.com/apache/airflow/pull/35085#issuecomment-1773840832
FYI @wolfdn Your fix is going to be integrated in 2.7.3 :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
potiuk merged PR #35085:
URL: https://github.com/apache/airflow/pull/35085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on PR #35085:
URL: https://github.com/apache/airflow/pull/35085#issuecomment-1772882711
Rebased and resolved conflicts after @vincbeck's merged #34924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
potiuk commented on PR #35085:
URL: https://github.com/apache/airflow/pull/35085#issuecomment-1772816983
Due to a tight integration and override, that one would require a bit
careful review and double-checking whether all the changes 4.3.6 -> 4.3.9
--
This is an automated message from t
potiuk opened a new pull request, #35085:
URL: https://github.com/apache/airflow/pull/35085
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from 4.3.6.
It incorporates those changes:
* https://github.com/dpgaspar/Flask-AppBuilder/pull/2112
* https://github.co
11 matches
Mail list logo