Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
shlomiken commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1842494020 @potiuk - looks like this PR breaks get_first and get_records return type for snowflake for example , so instead of tuple we get a Dict. this also breaks SqlSensor this code

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1842870944 Use latest version of both Airflow and Snowflake provider. There were several fixes implemented after that one. Just make sure to upgrade everything to latest versions as they con

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1842873116 And make sure to fix any deprecation warnings you see and look at the release notes - of Snowflake provider. There were a few breaking changes that you might want to fix (some of the thi

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
shlomiken commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1843099193 @potiuk - thanks , i kinda figure that out after trying to play with different versions of common-sql and provider. what surprised me is that we used to get a tuple, then after upgr

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1843641268 > back to tuple. - what a mess:-) No. It is actually common right now. We use to have mess in the PAST . Now it's all straightforward. And the "other" options (like Dictionary) are

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1843644984 So if you want to avoid the mess - convert your code to use tuples and you will be good and everything will be straightend u for you (as is for users who are starting now and everything

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
shlomiken commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1843650816 @potiuk - i think i came out wrong - i really appreciate what have being done (sticking with standard DBAPI) the thing is meant is - we used to have tuple, then upgraded and got di

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1843655260 Not suure - might be problem with the async operators -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab