Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-09-03 Thread via GitHub
dstandish commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2326961978 related https://github.com/apache/airflow/pull/38914 https://github.com/apache/airflow/pull/39760 https://github.com/apache/airflow/issues/39680 https://github.com/apache/ai

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-27 Thread via GitHub
boring-cyborg[bot] commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2134188273 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-27 Thread via GitHub
uranusjr merged PR #39745: URL: https://github.com/apache/airflow/pull/39745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2132226647 Looks good @dstandish - are you good with it ? Avoiding server-side error is worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-26 Thread via GitHub
potiuk commented on code in PR #39745: URL: https://github.com/apache/airflow/pull/39745#discussion_r1615204620 ## airflow/models/taskinstance.py: ## @@ -3476,8 +3476,13 @@ def _schedule_downstream_tasks( run_id=ti.run_id, ),

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-24 Thread via GitHub
dstandish commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2130232619 > > I know but it should be caught > > But the problem is this error produces unnecessary noise(with ERROR severity) in Postgres DB. That creates alerts, notifications, etc...

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-24 Thread via GitHub
VladimirYushkevich commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2129822063 > I know but it should be caught But the problem is this error produces unnecessary noise(with ERROR severity) in Postgres DB. That creates alerts, notifications, etc..

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-24 Thread via GitHub
dstandish commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2129640599 I know but it should be caught -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-23 Thread via GitHub
Taragolis commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2128453547 @dstandish this error happen on DB backend, e.g Postgres: - https://github.com/apache/airflow/issues/39781 - https://github.com/apache/airflow/issues/39680 -- This is an automa

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-23 Thread via GitHub
dstandish commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2128359199 > Related: #39680 In this changed argument from `nowait` to `skip_locked` for dag_run query. This allows to not rise DB error. Hi can you please share error you are getting and

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-23 Thread via GitHub
VladimirYushkevich commented on code in PR #39745: URL: https://github.com/apache/airflow/pull/39745#discussion_r1611708407 ## airflow/models/taskinstance.py: ## @@ -3476,8 +3476,13 @@ def _schedule_downstream_tasks( run_id=ti.run_id, ),

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-23 Thread via GitHub
dirrao commented on code in PR #39745: URL: https://github.com/apache/airflow/pull/39745#discussion_r1611693492 ## airflow/models/taskinstance.py: ## @@ -3476,8 +3476,13 @@ def _schedule_downstream_tasks( run_id=ti.run_id, ),

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-23 Thread via GitHub
Taragolis commented on code in PR #39745: URL: https://github.com/apache/airflow/pull/39745#discussion_r1611673291 ## airflow/models/taskinstance.py: ## @@ -3476,8 +3476,13 @@ def _schedule_downstream_tasks( run_id=ti.run_id, ),