Re: [PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] closed pull request #35316: Validate `dag.tasks` isn't empty when parsing URL: https://github.com/apache/airflow/pull/35316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-12-16 Thread via GitHub
github-actions[bot] commented on PR #35316: URL: https://github.com/apache/airflow/pull/35316#issuecomment-1858993604 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-11-01 Thread via GitHub
jedcunningham commented on PR #35316: URL: https://github.com/apache/airflow/pull/35316#issuecomment-1789072738 Ah, I like the deserialize idea, good catch all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-11-01 Thread via GitHub
ashb commented on PR #35316: URL: https://github.com/apache/airflow/pull/35316#issuecomment-1788601439 Another option would be to deserialise the dag before writing/committing - that way any deser error is caught? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-11-01 Thread via GitHub
ephraimbuddy commented on code in PR #35316: URL: https://github.com/apache/airflow/pull/35316#discussion_r1378466063 ## airflow/models/dag.py: ## @@ -746,6 +747,17 @@ def validate_setup_teardown(self): raise ValueError("Setup tasks must be followed with

Re: [PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-11-01 Thread via GitHub
ephraimbuddy commented on code in PR #35316: URL: https://github.com/apache/airflow/pull/35316#discussion_r1378466063 ## airflow/models/dag.py: ## @@ -746,6 +747,17 @@ def validate_setup_teardown(self): raise ValueError("Setup tasks must be followed with

Re: [PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-10-31 Thread via GitHub
jedcunningham commented on code in PR #35316: URL: https://github.com/apache/airflow/pull/35316#discussion_r1378317608 ## airflow/models/dag.py: ## @@ -746,6 +747,17 @@ def validate_setup_teardown(self): raise ValueError("Setup tasks must be followed wit

[PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-10-31 Thread via GitHub
jedcunningham opened a new pull request, #35316: URL: https://github.com/apache/airflow/pull/35316 Somehow a DAG ended up in a state where `dag.tasks` was empty, but the root tasks group had an operator. I'm not sure how it got in this state, but it does kill the scheduler, and since it's e