github-actions[bot] closed pull request #36227: WIP KPO log cleanup
URL: https://github.com/apache/airflow/pull/36227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
github-actions[bot] commented on PR #36227:
URL: https://github.com/apache/airflow/pull/36227#issuecomment-1922529710
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
dstandish commented on PR #36227:
URL: https://github.com/apache/airflow/pull/36227#issuecomment-1861190610
> I agree that the test doesn't cover this check, but IMHO, we need to
update the test and not the code to aggregate the log lines if they are really
split for some reason.
Lik
hussein-awala commented on PR #36227:
URL: https://github.com/apache/airflow/pull/36227#issuecomment-1858923795
Just to make sure it was intentional, you didn't revert all the changes,
where you removed the statement that logs the error message:
```python
self.log.error(
"Error
dstandish commented on PR #36227:
URL: https://github.com/apache/airflow/pull/36227#issuecomment-1858377170
hey @troyharvey i actually do have something for you to try
there's actualy a read timeout parameter we can use for k8s log reads. you
can try it out with this patch
dstandish commented on PR #36227:
URL: https://github.com/apache/airflow/pull/36227#issuecomment-1856550024
also @troyharvey interestingly we have received reports of this happening
with DBT. it always seems to be DBT-related. we actually worked pretty hard to
reproduce but could not. but
dstandish commented on PR #36227:
URL: https://github.com/apache/airflow/pull/36227#issuecomment-1856504013
Hi @troyharvey , my secret master plan is to do a larger refactor of KPO
logging.
In short here's the plan:
* run a log fetcher in a thread per container
* each log fe
troyharvey commented on PR #36227:
URL: https://github.com/apache/airflow/pull/36227#issuecomment-1856462164
@dstandish Let me know if we can help test this. We have a long-running
KubernetesPodOperator running dbt and we had to turn off `get_logs` because of
timeout issues with the task di
dstandish opened a new pull request, #36227:
URL: https://github.com/apache/airflow/pull/36227
I am trying to clean up KPO logging logic a bit.
I was trying to better understand the logic in
https://github.com/apache/airflow/pull/34412. It occurred to me that one way
to understand w
