Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-11-03 Thread via GitHub
potiuk commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1792700269 Good to see this "per-provider" configuration feature... But that reminds me that we need a bit more "discovery" Look at "docs/apache-airflow-providers-celery" - there is configu

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-11-03 Thread via GitHub
potiuk commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1792690567 Nope. It looks cool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-11-03 Thread via GitHub
potiuk merged PR #35059: URL: https://github.com/apache/airflow/pull/35059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-11-03 Thread via GitHub
Piatachock commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1792114098 Andrey, thanks for your approval! Is there anything else that should be done to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-11-01 Thread via GitHub
Taragolis commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1788667369 Need to add test for this changes. For validate configuration, you might use `conf_vars` - context manager / decorator. Some samples: https://github.com/apache/airflow/b

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-10-31 Thread via GitHub
Piatachock commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1787167736 Thanks! Managed to build provider locally and test it on our managed solution. Works as expected -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-10-25 Thread via GitHub
Taragolis commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1778920067 > I'm actually trying to build provider package locally to check it in our Managed Airflow installation end-to-end. Do you, by any chance, know where should I look for any info on t

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-10-25 Thread via GitHub
Taragolis commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1778863223 > it in our Managed Airflow BTW, you or some one from the Yandex also could add link to Yandex Managed Service for Apache Airflow into [Airflow Ecosystem](https://airflow.apac

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-10-25 Thread via GitHub
Piatachock commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1778805964 > Static checks are failing Sorry, forgot to mark this PR as WIP. I'm actually trying to build provider package locally to check it in our Managed Airflow installation end-t

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-10-24 Thread via GitHub
Taragolis commented on code in PR #35059: URL: https://github.com/apache/airflow/pull/35059#discussion_r1370969011 ## airflow/providers/yandex/provider.yaml: ## @@ -70,3 +70,15 @@ hooks: connection-types: - hook-class-name: airflow.providers.yandex.hooks.yandex.YandexCloudBa

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-10-21 Thread via GitHub
eladkal commented on PR #35059: URL: https://github.com/apache/airflow/pull/35059#issuecomment-1774002746 Static checks are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Yandex dataproc deduce default service account [airflow]

2023-10-19 Thread via GitHub
Taragolis commented on code in PR #35059: URL: https://github.com/apache/airflow/pull/35059#discussion_r1365676440 ## airflow/providers/yandex/hooks/yandex.py: ## @@ -85,17 +85,24 @@ def get_connection_form_widgets() -> dict[str, Any]: ), } +@classmet

[PR] Yandex dataproc deduce default service account [airflow]

2023-10-19 Thread via GitHub
Piatachock opened a new pull request, #35059: URL: https://github.com/apache/airflow/pull/35059 New features for YandexCloud Provider: * Support User-Agent header parametrization via environent variable * Store Service Account ID from Connection in Hook; use it as default in DataprocCl