Lee-W opened a new pull request, #36585:
URL: https://github.com/apache/airflow/pull/36585
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
Lee-W opened a new pull request, #36586:
URL: https://github.com/apache/airflow/pull/36586
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
Lee-W closed pull request #36585: add deferrable mode to RedshiftDataOperator
URL: https://github.com/apache/airflow/pull/36585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dirrao commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1443646182
##
airflow/providers/amazon/aws/operators/redshift_data.py:
##
@@ -121,6 +126,11 @@ def execute(self, context: Context) ->
GetStatementResultResponseTypeDef | str:
dirrao commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1443646182
##
airflow/providers/amazon/aws/operators/redshift_data.py:
##
@@ -121,6 +126,11 @@ def execute(self, context: Context) ->
GetStatementResultResponseTypeDef | str:
Lee-W commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1444364917
##
airflow/providers/amazon/aws/operators/redshift_data.py:
##
@@ -87,6 +90,7 @@ def __init__(
aws_conn_id: str = "aws_default",
region: str | None =
Lee-W commented on PR #36586:
URL: https://github.com/apache/airflow/pull/36586#issuecomment-1890393594
> Couple of checks are failing. Can you add the units for the deferrable
mode?
Yep, this is still a work in progress. Will try to wrap it up next week
--
This is an automated mes
Taragolis commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1452896398
##
airflow/providers/amazon/aws/triggers/redshift_data.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
Lee-W commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1452987226
##
airflow/providers/amazon/aws/triggers/redshift_data.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lice
syedahsn commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1453780939
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +217,56 @@ def get_table_primary_key(
break
return pk_columns or Non
syedahsn commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1453781801
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +217,56 @@ def get_table_primary_key(
break
return pk_columns or Non
Lee-W commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1455238325
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +217,56 @@ def get_table_primary_key(
break
return pk_columns or None
+
Lee-W commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1455237630
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +217,56 @@ def get_table_primary_key(
break
return pk_columns or None
+
Taragolis commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1456241727
##
airflow/providers/amazon/aws/triggers/redshift_data.py:
##
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
syedahsn commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1456412652
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +216,54 @@ def get_table_primary_key(
break
return pk_columns or Non
syedahsn commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1456419985
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +216,54 @@ def get_table_primary_key(
break
return pk_columns or Non
Lee-W commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1456735776
##
airflow/providers/amazon/aws/triggers/redshift_data.py:
##
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lice
Lee-W commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1456736353
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +216,54 @@ def get_table_primary_key(
break
return pk_columns or None
+
Lee-W commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1457449456
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +216,54 @@ def get_table_primary_key(
break
return pk_columns or None
+
syedahsn commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1457834082
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +216,54 @@ def get_table_primary_key(
break
return pk_columns or Non
eladkal merged PR #36586:
URL: https://github.com/apache/airflow/pull/36586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
Lee-W commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1458113287
##
airflow/providers/amazon/aws/hooks/redshift_data.py:
##
@@ -201,3 +216,54 @@ def get_table_primary_key(
break
return pk_columns or None
+
22 matches
Mail list logo
