Lee-W closed pull request #36341: add impersonation_chain support when calling
Bigquery Operators in deferrable mode
URL: https://github.com/apache/airflow/pull/36341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Lee-W commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1907152942
as https://github.com/apache/airflow/pull/36849 has been merged, close this
one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Lee-W commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1899527739
Hi @m1racoli, thanks for your feedback! I just took a look at your new PRs.
Both of them look good. I think we might no longer need this PR, but I'll mark
it as draft for now before we
m1racoli commented on code in PR #36341:
URL: https://github.com/apache/airflow/pull/36341#discussion_r1455033407
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -3247,6 +3259,36 @@ def _format_schema_for_description(schema: dict) -> list:
return description
m1racoli commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1896215415
Based on my review comments I've taken another attempt on this in #36849.
That one should make it easier to use credentials from hooks in gcloud-aio
clients without much extra work.
m1racoli commented on code in PR #36341:
URL: https://github.com/apache/airflow/pull/36341#discussion_r1455033407
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -3247,6 +3259,36 @@ def _format_schema_for_description(schema: dict) -> list:
return description
m1racoli commented on code in PR #36341:
URL: https://github.com/apache/airflow/pull/36341#discussion_r1454943542
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -3247,6 +3259,36 @@ def _format_schema_for_description(schema: dict) -> list:
return description
m1racoli commented on code in PR #36341:
URL: https://github.com/apache/airflow/pull/36341#discussion_r1454943542
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -3247,6 +3259,36 @@ def _format_schema_for_description(schema: dict) -> list:
return description
m1racoli commented on code in PR #36341:
URL: https://github.com/apache/airflow/pull/36341#discussion_r1454943542
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -3247,6 +3259,36 @@ def _format_schema_for_description(schema: dict) -> list:
return description
Lee-W commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1868885843
> Lets wait for a fix in upstream first
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
eladkal commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1868760316
Lets wait for a fix in upstream first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Lee-W commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1868466527
> FYI We might get better impersonation support in gcloud-aio soon. :)
[talkiq/gcloud-aio#665](https://github.com/talkiq/gcloud-aio/pull/665)
This looks great! Should we use the
m1racoli commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1868290626
FYI We might get better impersonation support in gcloud-aio soon. :)
https://github.com/talkiq/gcloud-aio/pull/665
--
This is an automated message from the Apache Git Service.
To
13 matches
Mail list logo
