Re: [PR] add param proxy user for hive [airflow]

2023-12-19 Thread via GitHub
potiuk merged PR #36221: URL: https://github.com/apache/airflow/pull/36221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] add param proxy user for hive [airflow]

2023-12-18 Thread via GitHub
romsharon98 commented on PR #36221: URL: https://github.com/apache/airflow/pull/36221#issuecomment-1861182689 > I see it's NOT the same... But I also have. feeling this is a bit cryptic now : when extra_dejson = param => choose proxy user, when owner -> choos run_as. Shoudl we document it b

Re: [PR] add param proxy user for hive [airflow]

2023-12-16 Thread via GitHub
potiuk commented on PR #36221: URL: https://github.com/apache/airflow/pull/36221#issuecomment-1859062976 I see it's NOT the same... But I also have. feeling this is a bit cryptic now : when extra_dejson = param => choose proxy user, when owner -> choos run_as. Shoudl we document it better a

Re: [PR] add param proxy user for hive [airflow]

2023-12-16 Thread via GitHub
potiuk commented on PR #36221: URL: https://github.com/apache/airflow/pull/36221#issuecomment-1859062420 Hmm. Isn't it the same as (undocumented in the docstring) `run_as` ? Would not it be better to just document `run_as` (or if we think `proxy_user` is better name also documenting `run_as

Re: [PR] add param proxy user for hive [airflow]

2023-12-14 Thread via GitHub
nadavgross commented on code in PR #36221: URL: https://github.com/apache/airflow/pull/36221#discussion_r1426847708 ## airflow/providers/apache/hive/operators/hive.py: ## @@ -72,6 +72,7 @@ class HiveOperator(BaseOperator): "hiveconfs", "mapred_job_name",

Re: [PR] add param proxy user for hive [airflow]

2023-12-14 Thread via GitHub
romsharon98 commented on code in PR #36221: URL: https://github.com/apache/airflow/pull/36221#discussion_r1426767001 ## airflow/providers/apache/hive/operators/hive.py: ## @@ -72,6 +72,7 @@ class HiveOperator(BaseOperator): "hiveconfs", "mapred_job_name",

Re: [PR] add param proxy user for hive [airflow]

2023-12-14 Thread via GitHub
nadavgross commented on code in PR #36221: URL: https://github.com/apache/airflow/pull/36221#discussion_r1426750093 ## airflow/providers/apache/hive/operators/hive.py: ## @@ -72,6 +72,7 @@ class HiveOperator(BaseOperator): "hiveconfs", "mapred_job_name",

[PR] add param proxy user for hive [airflow]

2023-12-14 Thread via GitHub
romsharon98 opened a new pull request, #36221: URL: https://github.com/apache/airflow/pull/36221 Added an option to sent proxy_param in HiveOperator when allow it in the connection. --- **^ Add meaningful description above** Read the **[Pull Request Guid