Re: [PR] add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression [airflow]

2024-01-10 Thread via GitHub
vincbeck merged PR #36578: URL: https://github.com/apache/airflow/pull/36578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression [airflow]

2024-01-10 Thread via GitHub
vincbeck commented on code in PR #36578: URL: https://github.com/apache/airflow/pull/36578#discussion_r1447736675 ## tests/system/providers/amazon/aws/example_s3.py: ## @@ -200,7 +202,18 @@ def check_fn(files: list) -> bool: check_fn=check_fn, deferrable=True,

Re: [PR] add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression [airflow]

2024-01-10 Thread via GitHub
pankajkoti commented on code in PR #36578: URL: https://github.com/apache/airflow/pull/36578#discussion_r1447604749 ## tests/system/providers/amazon/aws/example_s3.py: ## @@ -200,7 +202,18 @@ def check_fn(files: list) -> bool: check_fn=check_fn, deferrable=True

Re: [PR] add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression [airflow]

2024-01-10 Thread via GitHub
phanikumv commented on code in PR #36578: URL: https://github.com/apache/airflow/pull/36578#discussion_r1447344954 ## tests/system/providers/amazon/aws/example_s3.py: ## @@ -200,7 +202,18 @@ def check_fn(files: list) -> bool: check_fn=check_fn, deferrable=True,

Re: [PR] add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression [airflow]

2024-01-09 Thread via GitHub
Lee-W commented on code in PR #36578: URL: https://github.com/apache/airflow/pull/36578#discussion_r1446763634 ## tests/system/providers/amazon/aws/example_s3.py: ## @@ -200,7 +202,18 @@ def check_fn(files: list) -> bool: check_fn=check_fn, deferrable=True,

Re: [PR] add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression [airflow]

2024-01-09 Thread via GitHub
vincbeck commented on code in PR #36578: URL: https://github.com/apache/airflow/pull/36578#discussion_r1446602251 ## tests/system/providers/amazon/aws/example_s3.py: ## @@ -200,7 +202,18 @@ def check_fn(files: list) -> bool: check_fn=check_fn, deferrable=True,

Re: [PR] add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression [airflow]

2024-01-08 Thread via GitHub
Lee-W commented on code in PR #36578: URL: https://github.com/apache/airflow/pull/36578#discussion_r1445594656 ## airflow/providers/amazon/aws/sensors/s3.py: ## @@ -121,6 +124,11 @@ def _check_key(self, key): # Reduce the set of metadata to size only

Re: [PR] add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression [airflow]

2024-01-08 Thread via GitHub
o-nikolas commented on code in PR #36578: URL: https://github.com/apache/airflow/pull/36578#discussion_r1445417180 ## airflow/providers/amazon/aws/triggers/s3.py: ## @@ -39,7 +39,9 @@ class S3KeyTrigger(BaseTrigger): :param wildcard_match: whether the bucket_key should be i