Re: [PR] adding callback hook for on/off state of dag [airflow]

github-actions[bot] commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2365374267 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] adding callback hook for on/off state of dag [airflow]

potiuk commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2268575630 Generally speaking - `airflow db migrate` should migrate the db - also all our tests are running migration up / down -including the latest changed - there is a separate step doing it be

Re: [PR] adding callback hook for on/off state of dag [airflow]

Bowrna commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2268245124 > @potiuk I have added the migration changes. But I am not sure how I can apply those changes and run the code to test the changes. I tried checking around the repo to find help, but I d

Re: [PR] adding callback hook for on/off state of dag [airflow]

Bowrna commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2251958456 @potiuk I have added the migration changes. But I am not sure how I can apply those changes and run the code to test the changes. I tried checking around the repo to find help, but I did

Re: [PR] adding callback hook for on/off state of dag [airflow]

github-actions[bot] commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2227145683 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] adding callback hook for on/off state of dag [airflow]

potiuk commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2102584708 > @uranusjr @potiuk Can you give me directions in this part? Look at history of `airflow/migrations` -> this is where migration scripts are maintained and we use alembic to generat

Re: [PR] adding callback hook for on/off state of dag [airflow]

Bowrna commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2100799176 > I have added the changes and included the toggle_dag_callback inside models. But I am not sure how I can test the changes that adds a new table. Can anyone guide me with any sample PR

Re: [PR] adding callback hook for on/off state of dag [airflow]

eladkal commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2093495628 > @eladkal I checked the other issue. It is about adding another mode drain to the paused/unpaused state of DAG. While this PR is to send a callback on this state change. in this PR it

Re: [PR] adding callback hook for on/off state of dag [airflow]

Bowrna commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2089667006 @eladkal I checked the other issue. It is about adding another mode drain to the paused/unpaused state of DAG. While this PR is to send a callback on this state change. in this PR it mon

Re: [PR] adding callback hook for on/off state of dag [airflow]

Bowrna commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2088810739 I have added the changes and included the toggle_dag_callback inside models. But I am not sure how I can test the changes that adds a new table. Can anyone guide me with any sample PR to

Re: [PR] adding callback hook for on/off state of dag [airflow]

uranusjr commented on code in PR #38683: URL: https://github.com/apache/airflow/pull/38683#discussion_r1555446852 ## airflow/callbacks/callback_requests.py: ## @@ -144,3 +144,27 @@ def __init__( ): super().__init__(full_filepath, processor_subdir=processor_subdir,

Re: [PR] adding callback hook for on/off state of dag [airflow]

potiuk commented on code in PR #38683: URL: https://github.com/apache/airflow/pull/38683#discussion_r1555005706 ## airflow/models/dag.py: ## @@ -690,6 +694,7 @@ def __init__( ) self.dagrun_timeout = dagrun_timeout self.sla_miss_callback = sla_m

Re: [PR] adding callback hook for on/off state of dag [airflow]

Bowrna commented on code in PR #38683: URL: https://github.com/apache/airflow/pull/38683#discussion_r1554794562 ## airflow/models/dag.py: ## @@ -690,6 +694,7 @@ def __init__( ) self.dagrun_timeout = dagrun_timeout self.sla_miss_callback = sla_m

Re: [PR] adding callback hook for on/off state of dag [airflow]

Bowrna commented on code in PR #38683: URL: https://github.com/apache/airflow/pull/38683#discussion_r1548239659 ## airflow/models/dag.py: ## @@ -690,6 +694,7 @@ def __init__( ) self.dagrun_timeout = dagrun_timeout self.sla_miss_callback = sla_m

[PR] adding callback hook for on/off state of dag [airflow]

Bowrna opened a new pull request, #38683: URL: https://github.com/apache/airflow/pull/38683 closes: #36516 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pu