Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-12-24 Thread via GitHub
potiuk closed pull request #34819: allow changing of config file from default for the KubernetesResourceBaseOperator URL: https://github.com/apache/airflow/pull/34819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-13 Thread via GitHub
eladkal commented on PR #34819: URL: https://github.com/apache/airflow/pull/34819#issuecomment-1761271366 tests are failing @chapm250 can you look into it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-09 Thread via GitHub
chapm250 commented on code in PR #34819: URL: https://github.com/apache/airflow/pull/34819#discussion_r1350417687 ## airflow/providers/cncf/kubernetes/operators/resource.py: ## @@ -61,20 +61,22 @@ def __init__( yaml_conf: str, namespace: str | None = None,

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-09 Thread via GitHub
chapm250 commented on code in PR #34819: URL: https://github.com/apache/airflow/pull/34819#discussion_r1350404713 ## airflow/providers/cncf/kubernetes/operators/resource.py: ## @@ -61,20 +61,22 @@ def __init__( yaml_conf: str, namespace: str | None = None,

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-08 Thread via GitHub
amoghrajesh commented on code in PR #34819: URL: https://github.com/apache/airflow/pull/34819#discussion_r1349849665 ## airflow/providers/cncf/kubernetes/operators/resource.py: ## @@ -61,20 +61,22 @@ def __init__( yaml_conf: str, namespace: str | None = None,

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-08 Thread via GitHub
hussein-awala commented on PR #34819: URL: https://github.com/apache/airflow/pull/34819#issuecomment-1752022092 I close an reopen it to execute all the tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-08 Thread via GitHub
hussein-awala closed pull request #34819: allow changing of config file from default for the KubernetesResourceBaseOperator URL: https://github.com/apache/airflow/pull/34819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-08 Thread via GitHub
hussein-awala commented on PR #34819: URL: https://github.com/apache/airflow/pull/34819#issuecomment-1751942261 The failed tests look unrelated to this change, let me check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-07 Thread via GitHub
boring-cyborg[bot] commented on PR #34819: URL: https://github.com/apache/airflow/pull/34819#issuecomment-1751842914 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-07 Thread via GitHub
chapm250 opened a new pull request, #34819: URL: https://github.com/apache/airflow/pull/34819 Currently the KubernetesResourceBaseOperator doesn't allow changing from the default K8s config_file location (unlike the KubernetesPodOperator), this change allows changing the config_file locatio