Re: [PR] bump debian to bookworm [airflow]

2023-10-31 Thread via GitHub
raphaelauv commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1786747994 ![image](https://github.com/apache/airflow/assets/10202690/556a1461-f5a7-4d7e-80d0-1c18f8435594) https://github.com/apache/airflow/pull/35286 -- This is an automated message

Re: [PR] bump debian to bookworm [airflow]

2023-10-31 Thread via GitHub
raphaelauv commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1786869948 @potiuk "467B942D3A79BD29" is the current "key" for mysql how do I compute the value from the debian12 release ? http://repo.mysql.com/apt/debian/dists/bookworm/

Re: [PR] bump debian to bookworm [airflow]

2023-10-31 Thread via GitHub
Taragolis commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1787443155 > "467B942D3A79BD29" is the current "key" for mysql Is it not working? For me it is look like the same for bookworm and bullseye There is no info in MySQL page yet about

Re: [PR] bump debian to bookworm [airflow]

2023-11-01 Thread via GitHub
raphaelauv commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1788808576 ``` 11.00 Selecting previously unselected package libmysqlclient-dev. (Reading database ... 33079 files and directories currently installed.) 11.02 Preparing to unpack .../lib

Re: [PR] bump debian to bookworm [airflow]

2023-11-01 Thread via GitHub
Taragolis commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1788848597 >sorry @Taragolis just realize the error is about mssql **y** and **s** ![image](https://github.com/apache/airflow/assets/3998685/cd8682e8-f678-4b3c-a376-a0bbcc1d995c)

Re: [PR] bump debian to bookworm [airflow]

2023-11-01 Thread via GitHub
raphaelauv commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1789021982 I can build locally the image `breeze ci-image build --force-build --python-image python:3.11-slim-bookworm --python 3.11` --- `But you need "committer" privileges for

Re: [PR] bump debian to bookworm [airflow]

2023-11-01 Thread via GitHub
potiuk commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1789845152 > But you need "committer" privileges for it. > @potiuk or @Taragolis what should we do about that ? thanks I think you should be able push your change as "main" to your fork, an

Re: [PR] bump debian to bookworm [airflow]

2023-11-01 Thread via GitHub
potiuk commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1789856336 BTW. Yes. i think it's about enough time after bookworm was released (more than year) to get all the "other" software to catch up already (without us loosing time on it). As menti

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
raphaelauv commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1790372305 this is the run in the main branch of my fork -> https://github.com/raphaelauv/airflow/actions/runs/6727169212 -- This is an automated message from the Apache Git Service. To respo

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
potiuk commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1790432213 Looks pretty good. celery integration test fails and production image need some fixes but other than that it seems almost working -- This is an automated message from the Apache Git Se

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
raphaelauv commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1790718161 celery integration fail was flaky ( rerun workerd ) thank to my last commit I could build locally the prod image ``` breeze prod-image build ``` github ac

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
potiuk commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1790778237 Looks great then. I might want to take it from here and add option to choose bookworm or bullseye as breeze option (but it might be a good exercise for you - happy to help with it :)

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
raphaelauv commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1790795621 ``` I might want to take it from here ``` I agree , thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
potiuk commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1790979710 Smth still not fine with K8S tests though it might be a CI issue - maybe you could run K8S tests locally and see if this is replicable locally (there is a really nice chapter explaining

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
potiuk commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1791329691 I pushed a fixup with `--debian-version` switch. Now you can choose which version you want to build. It also has release notes, documentation in "Build imaages" about it, and CI job that

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
potiuk commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1791330829 (you are co-author BTW). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
potiuk commented on PR #32004: URL: https://github.com/apache/airflow/pull/32004#issuecomment-1791572495 Closing this one as we have #35376 now (and looks like K8S tests are all green there so we are good. Thanks Again for being persistent and leading it! -- This is an automated m

Re: [PR] bump debian to bookworm [airflow]

2023-11-02 Thread via GitHub
potiuk closed pull request #32004: bump debian to bookworm URL: https://github.com/apache/airflow/pull/32004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m