Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

phanikumv merged PR #36523: URL: https://github.com/apache/airflow/pull/36523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

phanikumv commented on PR #36523: URL: https://github.com/apache/airflow/pull/36523#issuecomment-1884774292 > I also think this is a bit redundant. I like the time savings, but it complicates the code a bit to have result checking/hanlding in multiple places. I think if we move forward with

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

Lee-W commented on code in PR #36523: URL: https://github.com/apache/airflow/pull/36523#discussion_r1443601217 ## airflow/providers/amazon/aws/operators/batch.py: ## @@ -230,36 +230,55 @@ def hook(self) -> BatchClientHook: region_name=self.region_name, )

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

Lee-W commented on code in PR #36523: URL: https://github.com/apache/airflow/pull/36523#discussion_r1441146395 ## airflow/providers/amazon/aws/operators/batch.py: ## @@ -230,36 +230,55 @@ def hook(self) -> BatchClientHook: region_name=self.region_name, )

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

o-nikolas commented on code in PR #36523: URL: https://github.com/apache/airflow/pull/36523#discussion_r1440805825 ## airflow/providers/amazon/aws/operators/batch.py: ## @@ -230,36 +230,55 @@ def hook(self) -> BatchClientHook: region_name=self.region_name,

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

potiuk commented on PR #36523: URL: https://github.com/apache/airflow/pull/36523#issuecomment-1875481928 > I see, I dont necessarily agree but I'll wait others to comment, I might be the only grumpy one here :) Just a little grumpy, I think :) > Yes, I think that's something we

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

vincbeck commented on PR #36523: URL: https://github.com/apache/airflow/pull/36523#issuecomment-1875470814 > > If the condition is already met and the task is deferred, what happens? My understanding is the task gets executed successfully. So the gain here is just time? Instead of deferring

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

Lee-W commented on PR #36523: URL: https://github.com/apache/airflow/pull/36523#issuecomment-1874715083 > If the condition is already met and the task is deferred, what happens? My understanding is the task gets executed successfully. So the gain here is just time? Instead of deferring the

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

vincbeck commented on PR #36523: URL: https://github.com/apache/airflow/pull/36523#issuecomment-1874430694 If the condition is already met and the task is deferred, what happens? My understanding is the task gets executed successfully. So the gain here is just time? Instead of deferring the

[PR] check job_status before BatchOperator execute in deferrable mode [airflow]

Lee-W opened a new pull request, #36523: URL: https://github.com/apache/airflow/pull/36523 … --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-gui