Re: [PR] confirmation dialog box for DAG run actions [airflow]

2024-02-12 Thread via GitHub
bbovenzi merged PR #35393: URL: https://github.com/apache/airflow/pull/35393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2024-02-12 Thread via GitHub
bbovenzi commented on PR #35393: URL: https://github.com/apache/airflow/pull/35393#issuecomment-1938998472 > Something failed last time - looks like intermittent EOF on docker build. I rebased to see if it is OK I just rebased again. Will merge if everything is green. -- This is

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2024-01-30 Thread via GitHub
potiuk commented on PR #35393: URL: https://github.com/apache/airflow/pull/35393#issuecomment-1916637582 Something failed last time - looks like intermittent EOF on docker build. I rebased to see if it is OK -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2024-01-29 Thread via GitHub
amoghrajesh commented on PR #35393: URL: https://github.com/apache/airflow/pull/35393#issuecomment-1916093168 @bbovenzi @potiuk are we good for a merge here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2024-01-17 Thread via GitHub
amoghrajesh commented on PR #35393: URL: https://github.com/apache/airflow/pull/35393#issuecomment-1897788669 @bbovenzi @pierrejeambrun can you take another look at this when you have some time? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-12-07 Thread via GitHub
theaadya commented on PR #35393: URL: https://github.com/apache/airflow/pull/35393#issuecomment-1845413662 Done with the requested changes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-12-04 Thread via GitHub
theaadya commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1414319928 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-30 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1411341407 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-29 Thread via GitHub
bbovenzi commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1409633670 ## airflow/www/static/js/dag/details/dagRun/ActionModal.tsx: ## @@ -0,0 +1,99 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-29 Thread via GitHub
bbovenzi commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1409632000 ## airflow/www/static/js/dag/details/dagRun/ClearRun.tsx: ## @@ -59,31 +60,67 @@ const ClearRun = ({ runId, ...otherProps }: Props) => { onQueue({ confirmed:

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-29 Thread via GitHub
bbovenzi commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1409630534 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-29 Thread via GitHub
bbovenzi commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1409626735 ## airflow/www/static/js/dag/details/dagRun/ClearRun.tsx: ## @@ -59,31 +60,67 @@ const ClearRun = ({ runId, ...otherProps }: Props) => { onQueue({ confirmed:

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-28 Thread via GitHub
theaadya commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1407580794 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-26 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1405477686 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-26 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1405477319 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-26 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1405477686 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-26 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1405477686 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-26 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1405477686 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-26 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1405477686 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-26 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1405477686 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-26 Thread via GitHub
pierrejeambrun commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1405477319 ## airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx: ## @@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-22 Thread via GitHub
theaadya commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1401938426 ## airflow/www/static/js/dag/details/dagRun/ClearRun.tsx: ## @@ -59,31 +60,57 @@ const ClearRun = ({ runId, ...otherProps }: Props) => { onQueue({ confirmed:

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-17 Thread via GitHub
theaadya commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1398050320 ## airflow/www/static/js/dag/details/dagRun/ClearRun.tsx: ## @@ -59,31 +60,57 @@ const ClearRun = ({ runId, ...otherProps }: Props) => { onQueue({ confirmed:

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-17 Thread via GitHub
bbovenzi commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1397937250 ## airflow/www/static/js/dag/details/dagRun/ClearRun.tsx: ## @@ -59,31 +60,57 @@ const ClearRun = ({ runId, ...otherProps }: Props) => { onQueue({ confirmed:

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-17 Thread via GitHub
bbovenzi commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1397742751 ## airflow/www/static/js/dag/details/dagRun/ActionModal.tsx: ## @@ -0,0 +1,100 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-17 Thread via GitHub
theaadya commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1397710021 ## airflow/www/static/js/dag/details/dagRun/ActionModal.tsx: ## @@ -0,0 +1,100 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] confirmation dialog box for DAG run actions [airflow]

2023-11-17 Thread via GitHub
theaadya commented on code in PR #35393: URL: https://github.com/apache/airflow/pull/35393#discussion_r1397707505 ## airflow/www/static/js/dag/details/dagRun/ActionModal.tsx: ## @@ -0,0 +1,100 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more