Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438561216 ## docs/apache-airflow-providers-microsoft-azure/operators/azure_synapse.rst: ## @@ -41,6 +41,17 @@ Below is an example of using this operator to execute a Spark app

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438561216 ## docs/apache-airflow-providers-microsoft-azure/operators/azure_synapse.rst: ## @@ -41,6 +41,17 @@ Below is an example of using this operator to execute a Spark app

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
Lymah123 commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438577562 ## docs/apache-airflow-providers-microsoft-azure/operators/azure_synapse.rst: ## @@ -41,6 +41,17 @@ Below is an example of using this operator to execute a Spark ap

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438579596 ## docs/apache-airflow-providers-microsoft-azure/operators/azure_synapse.rst: ## @@ -41,6 +41,17 @@ Below is an example of using this operator to execute a Spark app

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
Lymah123 commented on PR #36495: URL: https://github.com/apache/airflow/pull/36495#issuecomment-1872522385 @eladkal , I guessed I have worked on your suggestions. Let me know if there is any other thing. Thanks! -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438594362 ## tests/system/providers/microsoft/azure/example_synapse_run_pipeline.py: ## @@ -36,6 +36,14 @@ catchup=False, tags=["synapse", "example"], ) as dag: +

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
Lymah123 commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438606960 ## tests/system/providers/microsoft/azure/example_synapse_run_pipeline.py: ## @@ -36,6 +36,14 @@ catchup=False, tags=["synapse", "example"], ) as dag: +

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
Lymah123 commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438609313 ## tests/system/providers/microsoft/azure/example_synapse_run_pipeline.py: ## @@ -36,6 +36,14 @@ catchup=False, tags=["synapse", "example"], ) as dag: +

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438612830 ## tests/system/providers/microsoft/azure/example_synapse_run_pipeline.py: ## @@ -36,6 +36,14 @@ catchup=False, tags=["synapse", "example"], ) as dag: +

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
Lymah123 commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438616450 ## tests/system/providers/microsoft/azure/example_synapse_run_pipeline.py: ## @@ -36,6 +36,14 @@ catchup=False, tags=["synapse", "example"], ) as dag: +

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438625527 ## tests/system/providers/microsoft/azure/example_synapse_run_pipeline.py: ## @@ -36,6 +36,14 @@ catchup=False, tags=["synapse", "example"], ) as dag: +

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
Lymah123 commented on PR #36495: URL: https://github.com/apache/airflow/pull/36495#issuecomment-1872570175 Hi @eladkal , I have seen the duplicate you're talking about. You can check again. Thanks for being patient with me. -- This is an automated message from the Apache Git Ser

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438669477 ## tests/system/providers/microsoft/azure/example_synapse_run_pipeline.py: ## @@ -36,15 +36,15 @@ catchup=False, tags=["synapse", "example"], ) as dag: -

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438670195 ## docs/apache-airflow-providers-microsoft-azure/operators/azure_synapse.rst: ## @@ -41,6 +41,17 @@ Below is an example of using this operator to execute a Spark app

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
Lymah123 commented on PR #36495: URL: https://github.com/apache/airflow/pull/36495#issuecomment-1872669178 @eladkal , you can review it again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438831923 ## docs/apache-airflow-providers-microsoft-azure/operators/azure_synapse.rst: ## @@ -41,6 +41,17 @@ Below is an example of using this operator to execute a Spark app

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-30 Thread via GitHub
Lymah123 commented on PR #36495: URL: https://github.com/apache/airflow/pull/36495#issuecomment-1872792827 > LGTM Will merge when tests are green > LGTM Will merge when tests are green Yaay! Thanks for being patient with me. @eladkal ! Like how you give feedback! --

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-31 Thread via GitHub
eladkal commented on code in PR #36495: URL: https://github.com/apache/airflow/pull/36495#discussion_r1438847929 ## docs/apache-airflow-providers-microsoft-azure/operators/azure_synapse.rst: ## @@ -41,6 +41,17 @@ Below is an example of using this operator to execute a Spark app

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-31 Thread via GitHub
eladkal merged PR #36495: URL: https://github.com/apache/airflow/pull/36495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-31 Thread via GitHub
boring-cyborg[bot] commented on PR #36495: URL: https://github.com/apache/airflow/pull/36495#issuecomment-1872887662 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] docs: `Add AzureSynapseRunPipelineOperator` [airflow]

2023-12-31 Thread via GitHub
eladkal commented on PR #36495: URL: https://github.com/apache/airflow/pull/36495#issuecomment-1872888025 congrats @Lymah123 on your first merged PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go