Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-04-03 Thread via GitHub
github-actions[bot] closed pull request #35633: feat(helm): Add `enable` property to metric-exporter sidecar URL: https://github.com/apache/airflow/pull/35633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-03-29 Thread via GitHub
github-actions[bot] commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-2027836355 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-02-11 Thread via GitHub
V0lantis commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-1937827244 Hello, Run the tests and all seem to be good. Thanks @potiuk for the speedy reaction time ! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-01-08 Thread via GitHub
potiuk commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-1881864913 Nicer diagnostics for that case and instructions how to reinstall breeze with lower python version: https://github.com/apache/airflow/pull/36673 @V0lantis https://github.com/apach

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-01-08 Thread via GitHub
potiuk commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-1881825386 Make sure to setup global Python < 3.12 as your global Python version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-01-08 Thread via GitHub
V0lantis commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-1881602249 Because when I am committing and the pre-commit hook runs, [`Lint Helm Chart` installs `k8s_env`](https://github.com/apache/airflow/blob/f3ddefccf610833dc8d6012431f372f2af03053c/script

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-01-08 Thread via GitHub
eladkal commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-1881556126 > Updated with some tests. Couldn't tests everything because it seems there is some issue with pendulum installation and py3.12 [sdispater/pendulum#457 (comment)](https://github.com/sdi

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-01-08 Thread via GitHub
V0lantis commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-1881503659 Updated with some tests. Couldn't tests everything because it seems there is some issue with pendulum installation and py3.12 https://github.com/sdispater/pendulum/issues/457#issuecomm

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-01-04 Thread via GitHub
V0lantis commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-1876732241 Thank-you for the poke. I need to find the time to get into it soon. Will try to do it soon -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-01-03 Thread via GitHub
amoghrajesh commented on PR #35633: URL: https://github.com/apache/airflow/pull/35633#issuecomment-1876289265 @V0lantis are you still working on this/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2023-12-16 Thread via GitHub
hussein-awala commented on code in PR #35633: URL: https://github.com/apache/airflow/pull/35633#discussion_r1393074974 ## chart/values.schema.json: ## @@ -6086,6 +6086,11 @@ "x-docsSection": "PgBouncer", "additionalProperties": false,

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2023-11-17 Thread via GitHub
amoghrajesh commented on code in PR #35633: URL: https://github.com/apache/airflow/pull/35633#discussion_r1396860530 ## chart/values.yaml: ## @@ -2030,6 +2030,7 @@ pgbouncer: command: ["/bin/sh", "-c", "killall -INT pgbouncer && sleep 120"] metricsExporterSidecar:

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2023-11-14 Thread via GitHub
jedcunningham commented on code in PR #35633: URL: https://github.com/apache/airflow/pull/35633#discussion_r1393057315 ## chart/values.schema.json: ## @@ -6086,6 +6086,11 @@ "x-docsSection": "PgBouncer", "additionalProperties": false,

[PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2023-11-14 Thread via GitHub
V0lantis opened a new pull request, #35633: URL: https://github.com/apache/airflow/pull/35633 We have an issue with our Leboncoin's Airflow deployment where `metrics-exporter` sidecar was in `crashloopbackoff restart` because of its liveness probe. We figured out that we didn't need