Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-22 Thread via GitHub
Lee-W merged PR #41554: URL: https://github.com/apache/airflow/pull/41554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-21 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1724699557 ## airflow/providers/openai/hooks/openai.py: ## @@ -393,3 +417,76 @@ def delete_vector_store_file(self, vector_store_id: str, file_id: str) -> Vector """

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-21 Thread via GitHub
Lee-W commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1724629700 ## airflow/providers/openai/exceptions.py: ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreement

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-21 Thread via GitHub
Lee-W commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1724641016 ## airflow/providers/openai/hooks/openai.py: ## @@ -393,3 +417,76 @@ def delete_vector_store_file(self, vector_store_id: str, file_id: str) -> Vector """

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723161345 ## airflow/providers/openai/hooks/openai.py: ## @@ -43,9 +46,26 @@ ChatCompletionUserMessageParam, ) +from airflow.exceptions import AirflowException f

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723720593 ## tests/providers/openai/operators/test_openai.py: ## @@ -43,8 +65,53 @@ def test_execute_with_input_text(): @pytest.mark.parametrize("invalid_input", ["", None, 123]

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
vincbeck commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723718574 ## tests/providers/openai/operators/test_openai.py: ## @@ -43,8 +65,53 @@ def test_execute_with_input_text(): @pytest.mark.parametrize("invalid_input", ["", None, 1

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723715879 ## tests/providers/openai/operators/test_openai.py: ## @@ -43,8 +65,53 @@ def test_execute_with_input_text(): @pytest.mark.parametrize("invalid_input", ["", None, 123]

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723715459 ## tests/providers/openai/operators/test_openai.py: ## @@ -43,8 +65,53 @@ def test_execute_with_input_text(): @pytest.mark.parametrize("invalid_input", ["", None, 123]

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
vincbeck commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723688798 ## tests/providers/openai/operators/test_openai.py: ## @@ -48,3 +51,55 @@ def test_execute_with_invalid_input(invalid_input): context = Context() with pyte

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723257205 ## airflow/providers/openai/triggers/openai.py: ## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723614414 ## tests/providers/openai/operators/test_openai.py: ## @@ -48,3 +51,55 @@ def test_execute_with_invalid_input(invalid_input): context = Context() with pytest.

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
vincbeck commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723383044 ## tests/providers/openai/operators/test_openai.py: ## @@ -48,3 +51,55 @@ def test_execute_with_invalid_input(invalid_input): context = Context() with pyte

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723161345 ## airflow/providers/openai/hooks/openai.py: ## @@ -43,9 +46,26 @@ ChatCompletionUserMessageParam, ) +from airflow.exceptions import AirflowException f

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723262151 ## airflow/providers/openai/hooks/openai.py: ## @@ -393,3 +413,76 @@ def delete_vector_store_file(self, vector_store_id: str, file_id: str) -> Vector """

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723260595 ## airflow/providers/openai/hooks/openai.py: ## @@ -393,3 +413,76 @@ def delete_vector_store_file(self, vector_store_id: str, file_id: str) -> Vector """

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723260101 ## airflow/providers/openai/operators/openai.py: ## @@ -74,3 +78,92 @@ def execute(self, context: Context) -> list[float]: embeddings = self.hook.create_embedd

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723257847 ## airflow/providers/openai/operators/openai.py: ## @@ -74,3 +78,92 @@ def execute(self, context: Context) -> list[float]: embeddings = self.hook.create_embedd

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723257205 ## airflow/providers/openai/triggers/openai.py: ## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723161345 ## airflow/providers/openai/hooks/openai.py: ## @@ -43,9 +46,26 @@ ChatCompletionUserMessageParam, ) +from airflow.exceptions import AirflowException f

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
Lee-W commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723107795 ## airflow/providers/openai/hooks/openai.py: ## @@ -393,3 +413,76 @@ def delete_vector_store_file(self, vector_store_id: str, file_id: str) -> Vector """

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723089576 ## airflow/providers/openai/hooks/openai.py: ## @@ -393,3 +413,76 @@ def delete_vector_store_file(self, vector_store_id: str, file_id: str) -> Vector """

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723087191 ## airflow/providers/openai/hooks/openai.py: ## @@ -393,3 +413,76 @@ def delete_vector_store_file(self, vector_store_id: str, file_id: str) -> Vector """

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-20 Thread via GitHub
Lee-W commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1723033501 ## airflow/providers/openai/hooks/openai.py: ## @@ -43,9 +46,26 @@ ChatCompletionUserMessageParam, ) +from airflow.exceptions import AirflowException f

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-19 Thread via GitHub
josix commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1722639512 ## airflow/providers/openai/operators/openai.py: ## @@ -74,3 +78,86 @@ def execute(self, context: Context) -> list[float]: embeddings = self.hook.create_embedd

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-19 Thread via GitHub
vincbeck commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1722284792 ## airflow/providers/openai/operators/openai.py: ## @@ -74,3 +78,86 @@ def execute(self, context: Context) -> list[float]: embeddings = self.hook.create_emb

Re: [PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-19 Thread via GitHub
ginger0207 commented on code in PR #41554: URL: https://github.com/apache/airflow/pull/41554#discussion_r1721328153 ## airflow/providers/openai/hooks/openai.py: ## @@ -393,3 +413,74 @@ def delete_vector_store_file(self, vector_store_id: str, file_id: str) -> Vector """

[PR] feat(providers/openai): support batch api in hook/operator/trigger [airflow]

2024-08-17 Thread via GitHub
josix opened a new pull request, #41554: URL: https://github.com/apache/airflow/pull/41554 closes: #41336 - [x] Hook that supports batch api related operation - [x] Operator/Trigger for Batch API - [ ] Unit tests for new added behaviors to hook - [ ] Unit tests for ne