Re: [PR] feat: add read access to pools for viewer role [airflow]

2023-12-05 Thread via GitHub
eladkal merged PR #35352: URL: https://github.com/apache/airflow/pull/35352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: add read access to pools for viewer role [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35352: URL: https://github.com/apache/airflow/pull/35352#issuecomment-1834711150 > I'll wait for another approval before merging this. I just want to be sure that there is no historical reason for having it this way in the first place. You get it :) -- This

Re: [PR] feat: add read access to pools for viewer role [airflow]

2023-11-29 Thread via GitHub
raphaelauv commented on PR #35352: URL: https://github.com/apache/airflow/pull/35352#issuecomment-1831705291 the test `test_get_user_roles_for_anonymous_user` is failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] feat: add read access to pools for viewer role [airflow]

2023-11-28 Thread via GitHub
raphaelauv commented on PR #35352: URL: https://github.com/apache/airflow/pull/35352#issuecomment-1829723850 @marekhanus could you please rebase on main , to trigger a new CI test run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] feat: add read access to pools for viewer role [airflow]

2023-11-10 Thread via GitHub
marekhanus commented on PR #35352: URL: https://github.com/apache/airflow/pull/35352#issuecomment-1806267400 Rebase done. Conflicts after https://github.com/apache/airflow/commit/ad717ef50d58bfc442f62a7da03e2a77acd636b9 are now resolved. -- This is an automated message from the Apache

Re: [PR] feat: add read access to pools for viewer role [airflow]

2023-11-06 Thread via GitHub
raphaelauv commented on PR #35352: URL: https://github.com/apache/airflow/pull/35352#issuecomment-1794877998 @marekhanus if your PR is ready you could set it in "ready for review" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] feat: add read access to pools for viewer role [airflow]

2023-11-01 Thread via GitHub
boring-cyborg[bot] commented on PR #35352: URL: https://github.com/apache/airflow/pull/35352#issuecomment-1789254629 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] feat: add read access to pools for viewer role [airflow]

2023-11-01 Thread via GitHub
marekhanus opened a new pull request, #35352: URL: https://github.com/apache/airflow/pull/35352 Cluster Activity UI shows `FAILED TO FETCH DATA` error in pools section. Users with Viewer role do not have permission to read pools. --- **^ Add meaningful