[PR] feat: support mysql backend as keda trigger [airflow]

2023-12-11 Thread via GitHub
claneys opened a new pull request, #36167: URL: https://github.com/apache/airflow/pull/36167 related: #36166 Airflow currently support two SQL database backend with postgresql and mysql. PostgreSQL being the default one it's also the trigger used by default by the Keda ScaledObject c

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2023-12-11 Thread via GitHub
boring-cyborg[bot] commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1850068157 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2023-12-16 Thread via GitHub
hussein-awala commented on code in PR #36167: URL: https://github.com/apache/airflow/pull/36167#discussion_r1428977552 ## chart/templates/_helpers.yaml: ## @@ -84,7 +84,7 @@ If release name contains chart name it will be used as a full name. name: {{ template "airflow_

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2023-12-18 Thread via GitHub
claneys commented on code in PR #36167: URL: https://github.com/apache/airflow/pull/36167#discussion_r1430139667 ## chart/templates/_helpers.yaml: ## @@ -84,7 +84,7 @@ If release name contains chart name it will be used as a full name. name: {{ template "airflow_metada

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2023-12-18 Thread via GitHub
claneys commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1860490002 > Could you add tests for mounted secret, kedaConnection value, and KEDA scaler when the protocol is MySQL? Yes, Sure :) -- This is an automated message from the Apache Git Ser

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2024-01-03 Thread via GitHub
claneys commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1875108037 Hi @hussein-awala, Happy new year :) Is the changes fine to you ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2024-01-19 Thread via GitHub
eladkal commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1900951281 static checks are failing @claneys can you fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2024-01-20 Thread via GitHub
claneys commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1902099723 @eladkal Sure, I update the PR to make it pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2024-01-20 Thread via GitHub
eladkal commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1902171004 @claneys static tests are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2024-01-20 Thread via GitHub
potiuk merged PR #36167: URL: https://github.com/apache/airflow/pull/36167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2024-01-20 Thread via GitHub
boring-cyborg[bot] commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1902265914 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.