Re: [PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-18 Thread via GitHub
fritz-astronomer commented on PR #40638: URL: https://github.com/apache/airflow/pull/40638#issuecomment-2237194301 Awesome! Thanks @gyli ! Excited for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-18 Thread via GitHub
boring-cyborg[bot] commented on PR #40638: URL: https://github.com/apache/airflow/pull/40638#issuecomment-2236311297 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-18 Thread via GitHub
potiuk merged PR #40638: URL: https://github.com/apache/airflow/pull/40638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-17 Thread via GitHub
gyli commented on PR #40638: URL: https://github.com/apache/airflow/pull/40638#issuecomment-2235260342 Hi @eladkal could you plz review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-13 Thread via GitHub
gyli commented on PR #40638: URL: https://github.com/apache/airflow/pull/40638#issuecomment-2226989836 @potiuk Test added. Please review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-09 Thread via GitHub
potiuk commented on PR #40638: URL: https://github.com/apache/airflow/pull/40638#issuecomment-2217194493 Could you please add a unit test covering it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-07 Thread via GitHub
boring-cyborg[bot] commented on PR #40638: URL: https://github.com/apache/airflow/pull/40638#issuecomment-2212554221 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-07 Thread via GitHub
gyli opened a new pull request, #40638: URL: https://github.com/apache/airflow/pull/40638 Closes: https://github.com/apache/airflow/issues/40361 Support jinja variable to be rendered in ObjectStoragePath as an operator argument. --- **^ Add meanin