Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-05-09 Thread via GitHub
Taragolis merged PR #38831: URL: https://github.com/apache/airflow/pull/38831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-05-07 Thread via GitHub
rawwar commented on PR #38831: URL: https://github.com/apache/airflow/pull/38831#issuecomment-2097679231 @Taragolis , all tests passed. can this be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-05-06 Thread via GitHub
rawwar commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1590980473 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -159,6 +172,10 @@ def get_conn(self) -> connection: ]: conn_args[arg_name] = arg_v

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-05-06 Thread via GitHub
rawwar commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1590966792 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -159,6 +172,10 @@ def get_conn(self) -> connection: ]: conn_args[arg_name] = arg_v

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-05-06 Thread via GitHub
rawwar commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1590966792 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -159,6 +172,10 @@ def get_conn(self) -> connection: ]: conn_args[arg_name] = arg_v

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1590101404 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -159,6 +172,10 @@ def get_conn(self) -> connection: ]: conn_args[arg_name] = ar

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-04-30 Thread via GitHub
Taragolis commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1584730034 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -113,6 +114,18 @@ def schema(self): def schema(self, value): self.database = value +@prop

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-04-27 Thread via GitHub
rawwar commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1581814020 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -113,6 +114,18 @@ def schema(self): def schema(self, value): self.database = value +@propert

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-04-27 Thread via GitHub
rawwar commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1581812721 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -113,6 +114,18 @@ def schema(self): def schema(self, value): self.database = value +@propert

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-04-17 Thread via GitHub
rawwar commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1569714270 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -113,6 +114,18 @@ def schema(self): def schema(self, value): self.database = value +@propert

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-04-14 Thread via GitHub
rawwar commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1564753091 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -113,6 +114,18 @@ def schema(self): def schema(self, value): self.database = value +@propert