github-actions[bot] commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-3183734170
### Backport successfully created: v3-0-test
Status
Branch
Result
kaxil merged PR #48557:
URL: https://github.com/apache/airflow/pull/48557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.ap
amoghrajesh commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-3134954157
@uranusjr could you take a look at this PR again when you have some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
perry2of5 commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-3104197985
FWIW, I think we should drop the log when overflow is caught since we don't
log other reasons for capping the delay.
--
This is an automated message from the Apache Git Service.
To
perry2of5 commented on code in PR #48557:
URL: https://github.com/apache/airflow/pull/48557#discussion_r2178644517
##
airflow-core/src/airflow/models/taskinstance.py:
##
@@ -1114,12 +1114,15 @@ def next_retry_datetime(self):
delay = self.task.retry_delay
if s
perry2of5 commented on code in PR #48557:
URL: https://github.com/apache/airflow/pull/48557#discussion_r2164711654
##
airflow-core/src/airflow/models/taskinstance.py:
##
@@ -1114,12 +1114,15 @@ def next_retry_datetime(self):
delay = self.task.retry_delay
if s
uranusjr commented on code in PR #48557:
URL: https://github.com/apache/airflow/pull/48557#discussion_r2162960997
##
airflow-core/src/airflow/models/taskinstance.py:
##
@@ -1114,12 +1114,15 @@ def next_retry_datetime(self):
delay = self.task.retry_delay
if se
perry2of5 commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-2998903252
Lower in the function the code ensures the delay isn’t longer than a day,
but it doesn’t log anything when it does so.
--
This is an automated message from the Apache Git Servi
perry2of5 commented on code in PR #48557:
URL: https://github.com/apache/airflow/pull/48557#discussion_r2162175204
##
airflow-core/src/airflow/models/taskinstance.py:
##
@@ -1114,12 +1114,15 @@ def next_retry_datetime(self):
delay = self.task.retry_delay
if s
uranusjr commented on code in PR #48557:
URL: https://github.com/apache/airflow/pull/48557#discussion_r2160707004
##
airflow-core/src/airflow/models/taskinstance.py:
##
@@ -1114,12 +1114,15 @@ def next_retry_datetime(self):
delay = self.task.retry_delay
if se
perry2of5 commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-2927615194
> Is it possible to localise the try-except block a bit more? Currently the
block is a bit too large IMO.
Done. Thanks for the feedback, it is much cleaner now.
--
This is an
perry2of5 commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-2910510824
Looking a little closer, we cap MAX_RETRY_DELAY at 24*60*60 so probably it
can't throw at line 1145 I'll need to be sure that isn't configurable at
run time, but as long as it is
perry2of5 commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-2910122722
The overflow error is likely two places:
on line 1120:
` min_backoff = math.ceil(delay.total_seconds() * (2 ** (self.try_number -
1)))`
And on line 1145:
[https://doc
uranusjr commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-2908749487
Is it possible to localise the try-except block a bit more? Currently the
block is a bit too large IMO.
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #48557:
URL: https://github.com/apache/airflow/pull/48557#issuecomment-2906077378
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
15 matches
Mail list logo
