bitomukesh commented on PR #41220:
URL: https://github.com/apache/airflow/pull/41220#issuecomment-2365143527
Changelist by Bito
This pull request implements the following key changes.
Key Change
Files Impacted
Feature Imp
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1769491677
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
jedcunningham commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1769030670
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) ->
eladkal commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1769015943
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
eladkal commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1769015943
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1768429618
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
eladkal commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1763097203
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
jedcunningham commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1762251369
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) ->
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1759665047
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1744708190
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1744708550
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1744708190
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
dirrao commented on PR #41220:
URL: https://github.com/apache/airflow/pull/41220#issuecomment-2306646157
> @dirrao can you add some details in the description? Just repeating the
commit message/title isn't very useful, and having to go grok 100+ lines of
change to know what the goal is isn'
jedcunningham commented on PR #41220:
URL: https://github.com/apache/airflow/pull/41220#issuecomment-2306377884
@dirrao can you add some details in the description? Just repeating the
commit message/title isn't very useful, and having to go grok 100+ lines of
change to know what the goal is
potiuk commented on PR #41220:
URL: https://github.com/apache/airflow/pull/41220#issuecomment-2301917787
@dirrao I have very little knowiedge of those but maybe look at the history
of the change and ping someone who was actively implementing it before? That's
the best way to find who might
dirrao commented on PR #41220:
URL: https://github.com/apache/airflow/pull/41220#issuecomment-2290616177
@potiuk / @eladkal
Can someone review this MR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dirrao commented on PR #41220:
URL: https://github.com/apache/airflow/pull/41220#issuecomment-2279851640
@jedcunningham / @hussein-awala
Can you review it whenever you are free?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1709431878
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -601,34 +601,31 @@ def cleanup_stuck_queued_tasks(self, tis:
list[TaskInstance]) -> list[
romsharon98 commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1709045782
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -601,34 +601,31 @@ def cleanup_stuck_queued_tasks(self, tis:
list[TaskInstance]) ->
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1708958057
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -601,34 +601,31 @@ def cleanup_stuck_queued_tasks(self, tis:
list[TaskInstance]) -> list[
romsharon98 commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1708712202
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -601,34 +601,31 @@ def cleanup_stuck_queued_tasks(self, tis:
list[TaskInstance]) ->
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1706897901
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str |
datetime) -> str:
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1706886426
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -601,34 +601,31 @@ def cleanup_stuck_queued_tasks(self, tis:
list[TaskInstance]) -> list[
romsharon98 commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1706741949
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -601,34 +601,31 @@ def cleanup_stuck_queued_tasks(self, tis:
list[TaskInstance]) ->
dirrao commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1706730600
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -601,34 +601,31 @@ def cleanup_stuck_queued_tasks(self, tis:
list[TaskInstance]) -> list[
romsharon98 commented on code in PR #41220:
URL: https://github.com/apache/airflow/pull/41220#discussion_r1705611703
##
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##
@@ -601,34 +601,31 @@ def cleanup_stuck_queued_tasks(self, tis:
list[TaskInstance]) ->
dirrao commented on PR #41220:
URL: https://github.com/apache/airflow/pull/41220#issuecomment-2270991658
@jedcunningham / @hussein-awala
Can you review it whenever you are free?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dirrao closed pull request #41220: kubernetes executor
cleanup_stuck_queued_tasks optimization
URL: https://github.com/apache/airflow/pull/41220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dirrao opened a new pull request, #41220:
URL: https://github.com/apache/airflow/pull/41220
kubernetes executor cleanup_stuck_queued_tasks optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
29 matches
Mail list logo
