JDarDagran opened a new pull request, #35794:
URL: https://github.com/apache/airflow/pull/35794
Add flat information schema query support in SQLParser.
This PR adds support for Redshift SQL.
Additional changes in OpenLineage SQL utils were neccessary. This is
vincbeck commented on PR #35794:
URL: https://github.com/apache/airflow/pull/35794#issuecomment-1823078460
@ferruzzi, you might be interested into this one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
o-nikolas commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1402643538
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ext
ferruzzi commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1402660284
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.extr
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1402679860
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ex
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1402686751
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ex
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1402687254
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ex
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1402686751
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ex
ferruzzi commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1419751811
##
airflow/providers/openlineage/sqlparser.py:
##
@@ -299,7 +304,8 @@ def create_information_schema_query(
is_cross_db: bool,
information_schema_co
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1422373360
##
airflow/providers/openlineage/sqlparser.py:
##
@@ -299,7 +304,8 @@ def create_information_schema_query(
is_cross_db: bool,
information_schema_
ferruzzi commented on PR #35794:
URL: https://github.com/apache/airflow/pull/35794#issuecomment-1863486361
Still waiting to resolve the conversation with Niko but other than that
discussion, the rest LGTM
--
This is an automated message from the Apache Git Service.
To respond to the messa
JDarDagran commented on PR #35794:
URL: https://github.com/apache/airflow/pull/35794#issuecomment-1864483777
Pinging @o-nikolas then :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
o-nikolas commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1433085459
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ext
o-nikolas commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1433087081
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ext
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1433215003
##
airflow/providers/openlineage/sqlparser.py:
##
@@ -299,7 +304,8 @@ def create_information_schema_query(
is_cross_db: bool,
information_schema_
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1433244403
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ex
JDarDagran commented on PR #35794:
URL: https://github.com/apache/airflow/pull/35794#issuecomment-1867423828
@ferruzzi it **seems** we're ready to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1439023100
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ex
potiuk commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1439034813
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.extra_
JDarDagran commented on code in PR #35794:
URL: https://github.com/apache/airflow/pull/35794#discussion_r1439035387
##
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##
@@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection:
conn_kwargs_dejson = self.conn.ex
JDarDagran commented on PR #35794:
URL: https://github.com/apache/airflow/pull/35794#issuecomment-1876924843
@ferruzzi @o-nikolas the PR is hanging for quite a long time. Is there
anything in particular that would need explanation or any action?
--
This is an automated message from the Ap
o-nikolas merged PR #35794:
URL: https://github.com/apache/airflow/pull/35794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
o-nikolas commented on PR #35794:
URL: https://github.com/apache/airflow/pull/35794#issuecomment-1877521008
> @ferruzzi @o-nikolas the PR is hanging for quite a long time. Is there
anything in particular that would need explanation or any action?
Dennis gave a LGTM in a previous comme
23 matches
Mail list logo