[PR] pt012 rule enabled for sftp [airflow]

2024-03-27 Thread via GitHub
Bowrna opened a new pull request, #38525: URL: https://github.com/apache/airflow/pull/38525 closes : #38270 related: #38270 fix PT012 checks for sftp. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.c

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-03-27 Thread via GitHub
Taragolis commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2022701746 - #38518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-03-27 Thread via GitHub
Bowrna commented on code in PR #38525: URL: https://github.com/apache/airflow/pull/38525#discussion_r1542331163 ## tests/providers/sftp/triggers/test_sftp.py: ## @@ -176,12 +176,11 @@ async def test_sftp_trigger_run_trigger_failure_state(self, mock_get_files_by_pa trig

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-03-27 Thread via GitHub
Bowrna commented on code in PR #38525: URL: https://github.com/apache/airflow/pull/38525#discussion_r1542338886 ## tests/providers/sftp/triggers/test_sftp.py: ## @@ -176,12 +176,11 @@ async def test_sftp_trigger_run_trigger_failure_state(self, mock_get_files_by_pa trig

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-03-27 Thread via GitHub
Bowrna commented on code in PR #38525: URL: https://github.com/apache/airflow/pull/38525#discussion_r1542371255 ## airflow/providers/sftp/triggers/sftp.py: ## @@ -134,7 +134,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]: # Break loop to avoid infinite

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-04-01 Thread via GitHub
Bowrna commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2031133957 hello @Taragolis I fixed the conflicts. could you check this PR and let me know your views? Thanks -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-04-02 Thread via GitHub
potiuk commented on code in PR #38525: URL: https://github.com/apache/airflow/pull/38525#discussion_r1548435066 ## airflow/providers/sftp/triggers/sftp.py: ## @@ -134,7 +134,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]: # Break loop to avoid infinite

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-04-02 Thread via GitHub
potiuk commented on code in PR #38525: URL: https://github.com/apache/airflow/pull/38525#discussion_r1548447743 ## airflow/providers/sftp/triggers/sftp.py: ## @@ -134,7 +134,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]: # Break loop to avoid infinite

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-04-02 Thread via GitHub
potiuk commented on code in PR #38525: URL: https://github.com/apache/airflow/pull/38525#discussion_r1548448354 ## tests/providers/sftp/triggers/test_sftp.py: ## @@ -176,12 +176,11 @@ async def test_sftp_trigger_run_trigger_failure_state(self, mock_get_files_by_pa trig