Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-04-04 Thread via GitHub
eladkal merged PR #38638: URL: https://github.com/apache/airflow/pull/38638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-04-04 Thread via GitHub
idantepper commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2038183985 i ran pre-commit and changed the order of the imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-04-03 Thread via GitHub
hussein-awala commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2035794498 You can check https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst to fix the static checks. -- This is an automated message from the Apache

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-04-03 Thread via GitHub
idantepper commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2035666372 hello, after having some issues with my developing environment now everything is done also added the change that hussein recommended. thanks -- This is an automated

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-03-30 Thread via GitHub
idantepper commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2028476360 i changed a little bit more, i don't want this to be a huge PR, after doing this changes i will continue to change also the other ones -- This is an automated message from the

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-03-30 Thread via GitHub
idantepper commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2028469294 i am goin over all of them right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to