[ 
https://issues.apache.org/jira/browse/AIRFLOW-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

zhongjiajie closed AIRFLOW-4111.
--------------------------------
    Resolution: Won't Fix

Close by XD-DENG review. reason as below:

I think it's changing the behaviour, and may cause concern (in my person 
opinion): Users have been used to the behaviour that all the default 
connections are somehow "fake" and they know that they need to go there 
configure explicitly.

Another example: I may be using a {{read+write}} DB account for 
{{sql_alchemy_conn}} ({{write}} permission must be provided), while I will use 
a {{read_only}} DB account for {{airflow_db}}. But your change will use the 
{{read+write}} DB account info in {{sql_alchemy_conn}} to configure 
{{airflow_db}}, which should not happen by default.

IMO, the concerns this PR brings > the pros it brings (also given that {{Data 
profiling/Ad Hoc Query/Known Events}} are all deprecated). Personally I would 
not merge it.

Hope this clarifies.

> Auto config airflow_db to database in initdb
> --------------------------------------------
>
>                 Key: AIRFLOW-4111
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4111
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: db
>    Affects Versions: 1.10.2
>            Reporter: zhongjiajie
>            Assignee: zhongjiajie
>            Priority: Minor
>              Labels: features
>             Fix For: 1.10.3
>
>
> Make `airflow initdb` auto configure `airflow_db` by reading and parsing
> alchemy url in `airflow.cfg` section `[core]` param `sql_alchemy_conn`.
>  
> `airflow_db` work on UI `Data profiling/Ad Hoc Query` and 
> `Data profiling/Known Events` but using default constant values
> which not user friendly, specially `Data profiling/Known Events`
> use conn_id `airflow_db` as example. 
>  
> And as we know that `airflow_db`, airflow backend database, are
> already define in `airflow.cfg` section `[core]` paratemeter
> `sql_alchemy_conn` but alchemy url type, this Jira ticket help us
> make it real.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to