Re: [PR] Updates to Teradata Provider [airflow]

2024-05-01 Thread via GitHub
SatishChGit closed pull request #39217: Updates to Teradata Provider URL: https://github.com/apache/airflow/pull/39217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Adding PR user validation for generate_issue_content_providers [airflow]

2024-05-01 Thread via GitHub
amoghrajesh opened a new pull request, #39359: URL: https://github.com/apache/airflow/pull/39359 Due to missing validation check for PR users, sometimes, it is possible that empty "@" can get into the issue content. See attached screenshot: ![Screenshot 2024-05-01 at 15

Re: [PR] Add new run type "triggered" to distinguish manual DAG runs and triggered DAG runs [airflow]

2024-05-01 Thread via GitHub
uranusjr commented on PR #37087: URL: https://github.com/apache/airflow/pull/37087#issuecomment-2089546284 I think this is superceded by https://github.com/apache/airflow/pull/39165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add new run type "triggered" to distinguish manual DAG runs and triggered DAG runs [airflow]

2024-05-01 Thread via GitHub
uranusjr closed pull request #37087: Add new run type "triggered" to distinguish manual DAG runs and triggered DAG runs URL: https://github.com/apache/airflow/pull/37087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FEAT] get all failed tasks errors in exception [airflow]

2024-05-01 Thread via GitHub
gaurav7261 commented on PR #39354: URL: https://github.com/apache/airflow/pull/39354#issuecomment-2089481089 > How about the test case when multiple parallel tasks failed? is that a valid scenario? yes, The current logic is iterating through all failed tasks, hitting `get_run_output` api

Re: [PR] [FEAT] raise exception with main notebook error in DatabricksRunNowDeferrableOperator [airflow]

2024-05-01 Thread via GitHub
Lee-W commented on PR #39110: URL: https://github.com/apache/airflow/pull/39110#issuecomment-2089452009 > Hi @Lee-W @pankajkoti , raised PR for runnow operator separately as discussed, please review #39354 Thanks for your prompt implementation! Will look into it today -- This is

Re: [PR] Fix logic of clean log for find cmd arg of retention [airflow]

2024-05-01 Thread via GitHub
goodseeyou closed pull request #39303: Fix logic of clean log for find cmd arg of retention URL: https://github.com/apache/airflow/pull/39303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Status of testing of Apache Airflow 2.9.1rc1 [airflow]

2024-05-01 Thread via GitHub
RyuSA commented on issue #39326: URL: https://github.com/apache/airflow/issues/39326#issuecomment-2089424172 ![image](https://github.com/apache/airflow/assets/12961775/4d59e26e-7c3c-4667-a6ba-8e380806e9fa) I confirmed my patch is in the rc1. 

[I] This function is deprecated. Please use `create_unique_id`. [airflow]

2024-05-01 Thread via GitHub
bmoon4 opened a new issue, #39356: URL: https://github.com/apache/airflow/issues/39356 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.8.4 ### What happened? I am using

Re: [PR] [FEAT] raise exception with main notebook error in DatabricksRunNowDeferrableOperator [airflow]

2024-05-01 Thread via GitHub
gaurav7261 commented on PR #39110: URL: https://github.com/apache/airflow/pull/39110#issuecomment-2089364303 Hi @Lee-W @pankajkoti , raised PR for runnow operator separately as discussed, please review https://github.com/apache/airflow/pull/39354 -- This is an automated message from the

Re: [PR] ADD prototype version dark mode for Airflow UI [airflow]

2024-05-01 Thread via GitHub
boring-cyborg[bot] commented on PR #39355: URL: https://github.com/apache/airflow/pull/39355#issuecomment-2089360402 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] ADD prototype version dark mode for Airflow UI [airflow]

2024-05-01 Thread via GitHub
YounHS opened a new pull request, #39355: URL: https://github.com/apache/airflow/pull/39355 related: #11334 We've been seeing requests for a dark mode feature in the Airflow UI for a while now. I tested it using docker-compose.yaml. After testing, I was able to set

Re: [I] smtp_default connection host/port is ignored when sending email [airflow]

2024-05-01 Thread via GitHub
bmoon4 commented on issue #37442: URL: https://github.com/apache/airflow/issues/37442#issuecomment-2089343933 Hi, I'm experiencing same issue. Airflow is not picking up variables from a connection (`smtp_default`). It is just looking for `env vars` such as `AIRFLOW__SMTP__` or conf

[PR] [FEAT] get all failed tasks errors in exception [airflow]

2024-05-01 Thread via GitHub
gaurav7261 opened a new pull request, #39354: URL: https://github.com/apache/airflow/pull/39354 1. logic for getting main notebook exception via `get_run_output` api calling and raising the exception with all failed tasks errors **^ Add meaningful

Re: [PR] Add new run type "triggered" to distinguish manual DAG runs and triggered DAG runs [airflow]

2024-05-01 Thread via GitHub
github-actions[bot] commented on PR #37087: URL: https://github.com/apache/airflow/pull/37087#issuecomment-2089321356 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [PR] Add the possibility of custom probes in flower helm deployment [airflow]

2024-05-01 Thread via GitHub
github-actions[bot] closed pull request #38069: Add the possibility of custom probes in flower helm deployment URL: https://github.com/apache/airflow/pull/38069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Upgrade pytest to v8 [airflow]

2024-05-01 Thread via GitHub
github-actions[bot] commented on PR #37151: URL: https://github.com/apache/airflow/pull/37151#issuecomment-2089321318 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [PR] Fix automatic termination issue in EmrOperator by ensuring `waiter_max_attempts` is set for deferrable triggers [airflow]

2024-05-01 Thread via GitHub
o-nikolas commented on code in PR #38658: URL: https://github.com/apache/airflow/pull/38658#discussion_r1586906672 ## tests/providers/amazon/aws/operators/test_emr_containers.py: ## @@ -144,6 +144,20 @@ def test_operator_defer(self, mock_submit_job, mock_check_query_status):

Re: [PR] Fix automatic termination issue in EmrOperator by ensuring `waiter_max_attempts` is set for deferrable triggers [airflow]

2024-05-01 Thread via GitHub
o-nikolas commented on PR #38658: URL: https://github.com/apache/airflow/pull/38658#issuecomment-2089264782 Tests need to pass after your rebase from main. Otherwise looks good to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
VertexToEdge commented on code in PR #39345: URL: https://github.com/apache/airflow/pull/39345#discussion_r1586902396 ## airflow/www/app.py: ## @@ -120,6 +120,10 @@ def create_app(config=None, testing=False): ) cookie_samesite_config = "Lax"

Re: [PR] Remove try_number shenanigans [airflow]

2024-05-01 Thread via GitHub
dstandish commented on code in PR #39336: URL: https://github.com/apache/airflow/pull/39336#discussion_r1586874582 ## tests/sensors/test_base.py: ## @@ -382,9 +398,12 @@ def _get_tis(): # Task is cleared sensor.clear() sensor_ti, dummy_ti = _get_tis()

Re: [PR] Remove try_number shenanigans [airflow]

2024-05-01 Thread via GitHub
dstandish commented on code in PR #39336: URL: https://github.com/apache/airflow/pull/39336#discussion_r1586872663 ## airflow/models/taskinstance.py: ## @@ -280,14 +280,13 @@ def clear_task_instances( ti.refresh_from_task(task) if

Re: [I] Mock all connections in `TestYandexCloudYqHook::test_select_results` [airflow]

2024-05-01 Thread via GitHub
dondaum commented on issue #39352: URL: https://github.com/apache/airflow/issues/39352#issuecomment-2089204662 Would be happy to take it over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix: sqa deprecations for airflow tests [airflow]

2024-05-01 Thread via GitHub
dondaum commented on PR #39299: URL: https://github.com/apache/airflow/pull/39299#issuecomment-2089195859 > > Fixed but still raise a warning > >

Re: [PR] Fix automatic termination issue in EmrOperator by ensuring `waiter_max_attempts` is set for deferrable triggers [airflow]

2024-05-01 Thread via GitHub
beobest2 commented on code in PR #38658: URL: https://github.com/apache/airflow/pull/38658#discussion_r1586861317 ## tests/providers/amazon/aws/operators/test_emr_containers.py: ## @@ -144,6 +144,20 @@ def test_operator_defer(self, mock_submit_job, mock_check_query_status):

Re: [I] Status of testing Providers that were prepared on May 01, 2024 [airflow]

2024-05-01 Thread via GitHub
dondaum commented on issue #39346: URL: https://github.com/apache/airflow/issues/39346#issuecomment-2089183283 #38961 is good. ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add `jmespath` as an explicit dependency [airflow]

2024-05-01 Thread via GitHub
jedcunningham merged PR #39350: URL: https://github.com/apache/airflow/pull/39350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (29a9a24a5f -> 4910c0439b)

2024-05-01 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 29a9a24a5f Refactor tests re sensor reschedule mode and try_number (#39351) add 4910c0439b Add `jmespath`

Re: [I] Add ability to disable a running DAG only after after it's in a finished state [airflow]

2024-05-01 Thread via GitHub
SangwanP commented on issue #22006: URL: https://github.com/apache/airflow/issues/22006#issuecomment-2089068306 I have an alternative solution; someone with a deeper knowledge of the code base can evaluate it: If one is able to 'disable' the schedule on a DAG, the 'drain' functionality

Re: [I] [AIP-49] Airflow support for OTEL traces [airflow]

2024-05-01 Thread via GitHub
KimboTodd commented on issue #37752: URL: https://github.com/apache/airflow/issues/37752#issuecomment-2089067948 We need better monitoring in astronomer and this would help a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Add ability to disable a running DAG only after after it's in a finished state [airflow]

2024-05-01 Thread via GitHub
eladkal commented on issue #22006: URL: https://github.com/apache/airflow/issues/22006#issuecomment-209489 @jscheffl The way I imagine it is that the drain status is temporary (for the duration of the drain). once drain is finished it should be switched to pause. So at any given time

Re: [I] Add ability to disable a running DAG only after after it's in a finished state [airflow]

2024-05-01 Thread via GitHub
jscheffl commented on issue #22006: URL: https://github.com/apache/airflow/issues/22006#issuecomment-200568 I feel linke when going into details of database, DAG model, REST API, CLI... UI Experience this is a very complex thing. I agree that this option is useful. On the other hand

Re: [PR] gitSync: add envFrom to support proxy settings from k8s secret [airflow]

2024-05-01 Thread via GitHub
rasulkarimov commented on PR #39031: URL: https://github.com/apache/airflow/pull/39031#issuecomment-2088870335 > look good, can you fix current tests to validate your changes? Thank you! Fixed tests. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Status of testing Providers that were prepared on May 01, 2024 [airflow]

2024-05-01 Thread via GitHub
Anush008 commented on issue #39346: URL: https://github.com/apache/airflow/issues/39346#issuecomment-2088866714 > Provider [qdrant: 1.1.0rc1](https://pypi.org/project/apache-airflow-providers-qdrant/1.1.0rc1) https://github.com/apache/airflow/pull/39273 Tested. Works as

(airflow) branch main updated (413698ed1d -> 29a9a24a5f)

2024-05-01 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 413698ed1d Use correct prefixes for distribution packages in provider documentation (#39341) add 29a9a24a5f

Re: [PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
dstandish merged PR #39351: URL: https://github.com/apache/airflow/pull/39351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Add ability to disable a running DAG only after after it's in a finished state [airflow]

2024-05-01 Thread via GitHub
eladkal commented on issue #22006: URL: https://github.com/apache/airflow/issues/22006#issuecomment-2088864728 I prefer option 1. We need to remember that pausing DAG can also be done from API/CLI and not just the UI. We can simply deprecate `is_paused_upon_creation` and replace it

Re: [PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
jedcunningham commented on code in PR #39351: URL: https://github.com/apache/airflow/pull/39351#discussion_r1586579778 ## tests/sensors/test_base.py: ## @@ -284,62 +284,59 @@ def test_ok_with_reschedule(self, make_sensor, time_machine, task_reschedules_fo if

Re: [I] Status of testing Providers that were prepared on May 01, 2024 [airflow]

2024-05-01 Thread via GitHub
gopidesupavan commented on issue #39346: URL: https://github.com/apache/airflow/issues/39346#issuecomment-2088845850 @eladkal https://github.com/apache/airflow/pull/39300 tested and working correctly. -- This is an automated message from the Apache Git Service. To respond to the message,

[I] Mock all connections in `TestYandexCloudYqHook::test_select_results` [airflow]

2024-05-01 Thread via GitHub
Taragolis opened a new issue, #39352: URL: https://github.com/apache/airflow/issues/39352 ### Body Originally reported in [Slack](https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1714533835490519) **Jed Cunningham 7:23 AM** Feels like we might have missed mocking

Re: [PR] ECS Executor: Set tasks to RUNNING state once active [airflow]

2024-05-01 Thread via GitHub
o-nikolas commented on code in PR #39212: URL: https://github.com/apache/airflow/pull/39212#discussion_r1586556327 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -400,7 +400,7 @@ def attempt_task_runs(self): else: task =

Re: [PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
dstandish commented on code in PR #39351: URL: https://github.com/apache/airflow/pull/39351#discussion_r1586546901 ## tests/sensors/test_base.py: ## @@ -284,62 +284,59 @@ def test_ok_with_reschedule(self, make_sensor, time_machine, task_reschedules_fo if

Re: [PR] adding callback hook for on/off state of dag [airflow]

2024-05-01 Thread via GitHub
Bowrna commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2088810739 I have added the changes and included the toggle_dag_callback inside models. But I am not sure how I can test the changes that adds a new table. Can anyone guide me with any sample PR

Re: [PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
dstandish commented on code in PR #39351: URL: https://github.com/apache/airflow/pull/39351#discussion_r1586529415 ## tests/sensors/test_base.py: ## @@ -284,62 +284,59 @@ def test_ok_with_reschedule(self, make_sensor, time_machine, task_reschedules_fo if

Re: [PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
dstandish commented on code in PR #39351: URL: https://github.com/apache/airflow/pull/39351#discussion_r1586529415 ## tests/sensors/test_base.py: ## @@ -284,62 +284,59 @@ def test_ok_with_reschedule(self, make_sensor, time_machine, task_reschedules_fo if

Re: [PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
dstandish commented on code in PR #39351: URL: https://github.com/apache/airflow/pull/39351#discussion_r1586525580 ## tests/sensors/test_base.py: ## @@ -284,62 +284,59 @@ def test_ok_with_reschedule(self, make_sensor, time_machine, task_reschedules_fo if

Re: [PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
jedcunningham commented on code in PR #39351: URL: https://github.com/apache/airflow/pull/39351#discussion_r1586522534 ## tests/sensors/test_base.py: ## @@ -284,62 +284,59 @@ def test_ok_with_reschedule(self, make_sensor, time_machine, task_reschedules_fo if

Re: [I] Status of testing of Apache Airflow 2.9.1rc1 [airflow]

2024-05-01 Thread via GitHub
jscheffl commented on issue #39326: URL: https://github.com/apache/airflow/issues/39326#issuecomment-2088781071 Checked and my patch is in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
jedcunningham commented on code in PR #39351: URL: https://github.com/apache/airflow/pull/39351#discussion_r1586519165 ## tests/sensors/test_base.py: ## @@ -284,62 +284,59 @@ def test_ok_with_reschedule(self, make_sensor, time_machine, task_reschedules_fo if

Re: [PR] Add `job_id` parameter to `BigQueryGetDataOperator` [airflow]

2024-05-01 Thread via GitHub
shahar1 commented on code in PR #39315: URL: https://github.com/apache/airflow/pull/39315#discussion_r1586508577 ## airflow/providers/google/cloud/operators/bigquery.py: ## @@ -1026,7 +1045,10 @@ def execute(self, context: Context): if not self.table_project_id:

Re: [PR] Add `jmespath` as an explicit dependency [airflow]

2024-05-01 Thread via GitHub
jedcunningham commented on code in PR #39350: URL: https://github.com/apache/airflow/pull/39350#discussion_r1586509024 ## airflow/providers/amazon/provider.yaml: ## @@ -103,6 +103,7 @@ dependencies: # We should investigate if we can upgrade to a newer version of lxml and

Re: [PR] Add `job_id` parameter to `BigQueryGetDataOperator` [airflow]

2024-05-01 Thread via GitHub
shahar1 commented on code in PR #39315: URL: https://github.com/apache/airflow/pull/39315#discussion_r1586508577 ## airflow/providers/google/cloud/operators/bigquery.py: ## @@ -1026,7 +1045,10 @@ def execute(self, context: Context): if not self.table_project_id:

[PR] Refactor tests re sensor reschedule mode and try_number [airflow]

2024-05-01 Thread via GitHub
dstandish opened a new pull request, #39351: URL: https://github.com/apache/airflow/pull/39351 It's a little clearer what's going on when we're not in a loop or behind an `assert...` helper function. Additionally I add asserts immediately after calling `clear`. This will make

Re: [PR] Amazon Bedrock - Knowledge Bases and Data Sources [airflow]

2024-05-01 Thread via GitHub
syedahsn commented on code in PR #39245: URL: https://github.com/apache/airflow/pull/39245#discussion_r1586500169 ## airflow/providers/amazon/aws/sensors/bedrock.py: ## @@ -211,3 +262,149 @@ def execute(self, context: Context) -> Any: ) else:

Re: [PR] Add `retry_from_failure` parameter to DbtCloudRunJobOperator [airflow]

2024-05-01 Thread via GitHub
boraberke commented on PR #38868: URL: https://github.com/apache/airflow/pull/38868#issuecomment-2088750430 @Lee-W, I have tested and here how it works: When first run already uses `steps_override, schema_override, additional_run_config` and the first run is failed, rerunning

Re: [PR] Amazon Bedrock - Knowledge Bases and Data Sources [airflow]

2024-05-01 Thread via GitHub
syedahsn commented on code in PR #39245: URL: https://github.com/apache/airflow/pull/39245#discussion_r1586497806 ## airflow/providers/amazon/aws/sensors/bedrock.py: ## @@ -211,3 +262,149 @@ def execute(self, context: Context) -> Any: ) else:

Re: [PR] Add `job_id` parameter to `BigQueryGetDataOperator` [airflow]

2024-05-01 Thread via GitHub
shahar1 commented on code in PR #39315: URL: https://github.com/apache/airflow/pull/39315#discussion_r1586490522 ## airflow/providers/google/cloud/operators/bigquery.py: ## @@ -1035,31 +1057,45 @@ def execute(self, context: Context): ) if not

Re: [PR] Add `job_id` parameter to `BigQueryGetDataOperator` [airflow]

2024-05-01 Thread via GitHub
shahar1 commented on code in PR #39315: URL: https://github.com/apache/airflow/pull/39315#discussion_r1586490522 ## airflow/providers/google/cloud/operators/bigquery.py: ## @@ -1035,31 +1057,45 @@ def execute(self, context: Context): ) if not

Re: [PR] Add `jmespath` as an explicit dependency [airflow]

2024-05-01 Thread via GitHub
Taragolis commented on code in PR #39350: URL: https://github.com/apache/airflow/pull/39350#discussion_r1586488684 ## airflow/providers/fab/provider.yaml: ## @@ -50,6 +50,7 @@ dependencies: - flask-appbuilder==4.4.1 - flask-login>=0.6.2 - google-re2>=1.0 + - jmsepath

Re: [PR] Add `job_id` parameter to `BigQueryGetDataOperator` [airflow]

2024-05-01 Thread via GitHub
shahar1 commented on code in PR #39315: URL: https://github.com/apache/airflow/pull/39315#discussion_r1586489531 ## airflow/providers/google/cloud/triggers/bigquery.py: ## @@ -235,7 +237,11 @@ async def run(self) -> AsyncIterator[TriggerEvent]: # type: ignore[override]

Re: [PR] Add unit tests for EksCreateClusterTrigger [airflow]

2024-05-01 Thread via GitHub
Taragolis commented on PR #39349: URL: https://github.com/apache/airflow/pull/39349#issuecomment-2088718716 You need to remove this line: https://github.com/apache/airflow/blob/c434c6b98911d71f27910d7d30cf966462157612/tests/always/test_project_structure.py#L75 -- This is an

Re: [I] Status of testing Providers that were prepared on May 01, 2024 [airflow]

2024-05-01 Thread via GitHub
wlinamchurch commented on issue #39346: URL: https://github.com/apache/airflow/issues/39346#issuecomment-2088714308 @eladkal https://github.com/apache/airflow/pull/38911 tested and working correctly. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Add missing test modules in our unit test suite [airflow]

2024-05-01 Thread via GitHub
Taragolis commented on issue #35442: URL: https://github.com/apache/airflow/issues/35442#issuecomment-2088704233 There is pretty simple rule there if providers module placed into the `airflow/providers/amazon/aws/operators/emr.py` then tests should be placed into the

[PR] Add unit tests for EksCreateClusterTrigger [airflow]

2024-05-01 Thread via GitHub
mateuslatrova opened a new pull request, #39349: URL: https://github.com/apache/airflow/pull/39349 Related: https://github.com/apache/airflow/issues/35442 This PR adds unit tests for the EksCreateClusterTrigger trigger from the Airflow AWS provider

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
Taragolis commented on code in PR #39345: URL: https://github.com/apache/airflow/pull/39345#discussion_r1586433872 ## airflow/www/app.py: ## @@ -120,6 +120,10 @@ def create_app(config=None, testing=False): ) cookie_samesite_config = "Lax"

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
bbovenzi commented on PR #39345: URL: https://github.com/apache/airflow/pull/39345#issuecomment-2088631413 Nice catch! We could probably cache it for a few weeks. Assets will only change between airflow version updates. -- This is an automated message from the Apache Git Service. To

Re: [I] Status of testing Providers that were prepared on May 01, 2024 [airflow]

2024-05-01 Thread via GitHub
dabla commented on issue #39346: URL: https://github.com/apache/airflow/issues/39346#issuecomment-2088602198 I know there is still an issue with the MSGraphSensor in that sense that it’s not working correctly in an async way and sometimes an event loop closed error can occur. This

Re: [PR] Use correct prefixes for distribution packages in provider documentation [airflow]

2024-05-01 Thread via GitHub
Taragolis commented on PR #39341: URL: https://github.com/apache/airflow/pull/39341#issuecomment-2088588913 > LGTM. Looks like this is due to recent pip support for underscore in packager names. This one about normalisation described in [PEP-625](https://peps.python.org/pep-0625/)

Re: [PR] [fix](doc)apache_airflow_providers_apache_flink download link failure [airflow]

2024-05-01 Thread via GitHub
eladkal commented on PR #39305: URL: https://github.com/apache/airflow/pull/39305#issuecomment-2088586224 Supressed by https://github.com/apache/airflow/pull/39341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](doc)apache_airflow_providers_apache_flink download link failure [airflow]

2024-05-01 Thread via GitHub
eladkal closed pull request #39305: [fix](doc)apache_airflow_providers_apache_flink download link failure URL: https://github.com/apache/airflow/pull/39305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(airflow) branch main updated: Use correct prefixes for distribution packages in provider documentation (#39341)

2024-05-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 413698ed1d Use correct prefixes for distribution

Re: [PR] Use correct prefixes for distribution packages in provider documentation [airflow]

2024-05-01 Thread via GitHub
eladkal merged PR #39341: URL: https://github.com/apache/airflow/pull/39341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Custom FAB actions no longer work [airflow]

2024-05-01 Thread via GitHub
TJaniF commented on issue #39144: URL: https://github.com/apache/airflow/issues/39144#issuecomment-2088554851 > is there a workaround for this until the fix is deployed? I can't run my dev environment locally If you are referring to the Astro CLI local environment you can set

Re: [I] Status of testing Providers that were prepared on May 01, 2024 [airflow]

2024-05-01 Thread via GitHub
nathadfield commented on issue #39346: URL: https://github.com/apache/airflow/issues/39346#issuecomment-2088553502 @eladkal #39248 and #38736 tested and working correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Custom FAB actions no longer work [airflow]

2024-05-01 Thread via GitHub
vincbeck commented on issue #39144: URL: https://github.com/apache/airflow/issues/39144#issuecomment-2088492522 Besides removing the `@has_access` from the view you defined in your plugin, I dont see any. I am not saying this is something you should do. It really depends on your setup and

Re: [I] Add missing test modules in our unit test suite [airflow]

2024-05-01 Thread via GitHub
mateuslatrova commented on issue #35442: URL: https://github.com/apache/airflow/issues/35442#issuecomment-2088490071 > @mateuslatrova Some test modules from your list do not exists or named differently > > ### Exists > I've marked this as completed > > *

Re: [I] Custom FAB actions no longer work [airflow]

2024-05-01 Thread via GitHub
tagoad commented on issue #39144: URL: https://github.com/apache/airflow/issues/39144#issuecomment-2088477101 is there a workaround for this until the fix is deployed? I can't run my dev environment locally -- This is an automated message from the Apache Git Service. To respond to the

(airflow) branch main updated: Fix Jira CHANGELOG.rst (#39347)

2024-05-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fd9f9efe68 Fix Jira CHANGELOG.rst (#39347)

Re: [PR] Fix Jira CHANGELOG.rst [airflow]

2024-05-01 Thread via GitHub
eladkal merged PR #39347: URL: https://github.com/apache/airflow/pull/39347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Modify KPO to log container log periodically [airflow]

2024-05-01 Thread via GitHub
pankajastro commented on PR #37279: URL: https://github.com/apache/airflow/pull/37279#issuecomment-2088470139 hmm, this will require small changes PR https://github.com/apache/airflow/pull/39348 -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Fetch intermediate log async GKEStartPod [airflow]

2024-05-01 Thread via GitHub
pankajastro opened a new pull request, #39348: URL: https://github.com/apache/airflow/pull/39348 --- **^ Add meaningful description above** Read the **[Pull Request

(airflow-site) branch add-documentation-2024-05-01 updated (07f08cdfe1 -> ead07a1760)

2024-05-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch add-documentation-2024-05-01 in repository https://gitbox.apache.org/repos/asf/airflow-site.git from 07f08cdfe1 Add documentation for packages - 2024-05-01 add ead07a1760 Fix duplicate

[PR] Fix Jira CHANGELOG.rst [airflow]

2024-05-01 Thread via GitHub
eladkal opened a new pull request, #39347: URL: https://github.com/apache/airflow/pull/39347 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[I] Status of testing Providers that were prepared on May 01, 2024 [airflow]

2024-05-01 Thread via GitHub
eladkal opened a new issue, #39346: URL: https://github.com/apache/airflow/issues/39346 ### Body I have a kind request for all the contributors to the latest provider packages release. Could you please help us to test the RC versions of the providers? The guidelines on how

[PR] Add documentation for packages - 2024-05-01 [airflow-site]

2024-05-01 Thread via GitHub
eladkal opened a new pull request, #1009: URL: https://github.com/apache/airflow-site/pull/1009 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(airflow-site) branch add-documentation-2024-05-01 created (now 07f08cdfe1)

2024-05-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch add-documentation-2024-05-01 in repository https://gitbox.apache.org/repos/asf/airflow-site.git at 07f08cdfe1 Add documentation for packages - 2024-05-01 This branch includes the

[PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
VertexToEdge opened a new pull request, #39345: URL: https://github.com/apache/airflow/pull/39345 close #39344 Above Airflow 2.3.0, webserver's static file caching is disabled because of major updated Flask's breaking change. In Flask 2.0.x, default value of

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-01 Thread via GitHub
boring-cyborg[bot] commented on PR #39345: URL: https://github.com/apache/airflow/pull/39345#issuecomment-2088394243 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

svn commit: r68905 [4/4] - /dev/airflow/providers/

2024-05-01 Thread eladkal
Added: dev/airflow/providers/apache_airflow_providers_salesforce-5.7.0.tar.gz.sha512 == --- dev/airflow/providers/apache_airflow_providers_salesforce-5.7.0.tar.gz.sha512 (added) +++

svn commit: r68905 [3/4] - /dev/airflow/providers/

2024-05-01 Thread eladkal
Added: dev/airflow/providers/apache_airflow_providers_http-4.11.0-py3-none-any.whl.asc == --- dev/airflow/providers/apache_airflow_providers_http-4.11.0-py3-none-any.whl.asc (added) +++

svn commit: r68905 [2/4] - /dev/airflow/providers/

2024-05-01 Thread eladkal
Added: dev/airflow/providers/apache_airflow_providers_apache_livy-3.8.0-py3-none-any.whl.sha512 == --- dev/airflow/providers/apache_airflow_providers_apache_livy-3.8.0-py3-none-any.whl.sha512 (added) +++

svn commit: r68905 [1/4] - /dev/airflow/providers/

2024-05-01 Thread eladkal
Author: eladkal Date: Wed May 1 11:53:48 2024 New Revision: 68905 Log: Add artifacts for Airflow Providers 2024-05-01 Added: dev/airflow/providers/apache_airflow_providers_airbyte-3.8.0-py3-none-any.whl (with props)

(airflow) branch main updated (7a0fa64997 -> fe4605a10e)

2024-05-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 7a0fa64997 Use `upload_files_v2` Slack SDK method by default in Slack Operators (#39340) add fe4605a10e Prepare

Re: [PR] Prepare docs 1st wave May 2024 [airflow]

2024-05-01 Thread via GitHub
eladkal merged PR #39328: URL: https://github.com/apache/airflow/pull/39328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] webserver static file caching is disabled above 2.3.0 version. [airflow]

2024-05-01 Thread via GitHub
Taragolis commented on issue #39344: URL: https://github.com/apache/airflow/issues/39344#issuecomment-2088326239 > if there is a better way to do this without changing the code Better way contribute this changes to Airflow codebase. I do not sure that you could provide additional

(airflow) branch main updated: Use `upload_files_v2` Slack SDK method by default in Slack Operators (#39340)

2024-05-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7a0fa64997 Use `upload_files_v2` Slack SDK method

Re: [PR] Use `upload_files_v2` Slack SDK method by default in Slack Operators [airflow]

2024-05-01 Thread via GitHub
eladkal merged PR #39340: URL: https://github.com/apache/airflow/pull/39340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] webserver static file caching is disabled above 2.3.0 version. [airflow]

2024-05-01 Thread via GitHub
boring-cyborg[bot] commented on issue #39344: URL: https://github.com/apache/airflow/issues/39344#issuecomment-2088277101 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[I] webserver static file caching is disabled above 2.3.0 version. [airflow]

2024-05-01 Thread via GitHub
VertexToEdge opened a new issue, #39344: URL: https://github.com/apache/airflow/issues/39344 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.3.x ~ 2.9.x ### What happened?

Re: [I] New release covering latest main [airflow]

2024-05-01 Thread via GitHub
Taragolis closed issue #39342: New release covering latest main URL: https://github.com/apache/airflow/issues/39342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   >