[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-26 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1242523152 ## tests/models/test_taskmixin.py: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-26 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1242515422 ## tests/models/test_taskmixin.py: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-26 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1242448482 ## tests/models/test_taskmixin.py: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-26 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1242441414 ## airflow/models/abstractoperator.py: ## @@ -149,6 +155,92 @@ def dag_id(self) -> str: def node_id(self) -> str: return self.task_id +

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-26 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1242429904 ## airflow/example_dags/example_setup_teardown_taskflow.py: ## @@ -29,30 +29,56 @@ catchup=False, tags=["example"], ) as dag: -# You can use the

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-26 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1242400515 ## airflow/models/abstractoperator.py: ## @@ -149,6 +155,92 @@ def dag_id(self) -> str: def node_id(self) -> str: return self.task_id +

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-26 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1242399648 ## airflow/models/abstractoperator.py: ## @@ -149,6 +155,92 @@ def dag_id(self) -> str: def node_id(self) -> str: return self.task_id +

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-26 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1242398202 ## airflow/models/abstractoperator.py: ## @@ -149,6 +155,92 @@ def dag_id(self) -> str: def node_id(self) -> str: return self.task_id +

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-23 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1240156463 ## airflow/example_dags/example_setup_teardown_taskflow.py: ## @@ -47,12 +45,10 @@ def normal(): @task_group def section_1(): # You can also

[GitHub] [airflow] dstandish commented on a diff in pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-22 Thread via GitHub
dstandish commented on code in PR #32053: URL: https://github.com/apache/airflow/pull/32053#discussion_r1239035805 ## airflow/models/taskmixin.py: ## @@ -69,6 +70,14 @@ def set_downstream( """Set a task or a task list to be directly downstream from the current