[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-08-30 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1698592280 FY: https://github.com/apache/airflow/issues/33909 I've added more of a "meta" Issue describing our goal about "splitting providers to subfolders" (for now - without starting

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-08-03 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1663638068 I think it's quite easy - follow the way configs were moved to providers. This is a very similar case. 1) add a "default_connections" config somewhere in provider.yaml

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-07-08 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1627456200 Yes. We can't really change db init behaviour. But we can do something else. We can deprecate (and hide) `init` and add a new `initialize` command that should only work on empty db

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-06-23 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1605064459 But yes. I am all for clarifying the behaviour, getting `airflow db init` to be renamed and defining when we create default conneciotns (and whether they should be coming from

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-06-23 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1605062163 > How do we decide which providers would have default connections out of the box or in the past, since I don't see it for all of them? were there any criteria to be met? > >

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-06-21 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1601571872 > IMO we can just change the default value of database.load_default_connections to False, and we will stop loading them by default, and the users can still load them by setting

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-06-21 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1600742242 You have to remember that if you follow the advice: > Do not use airflow db init as it can create a lot of default connections, charts, etc. which are not required in

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-06-21 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1600739433 > My goal is that providers will be able to add new connections in the UI without forcing user to update Airflow version This is already happening. You do not need to run

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-06-21 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1600733529 I am not sure if this is really needed. As discussed in https://github.com/apache/airflow/pull/31533#discussion_r1236891857 "airflow db init" is mostly a "try and test" feature.