potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1691529880
> > @hamedhsn Could you check the failed tests?
>
> sorry, there is no point in updating this code anymore as there is no
intention of reviewing/merging this PR.
Why do you
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1630679609
> @potiuk checks are passed. when can this be merged?
When others take a look and confirm it's a good idea.
--
This is an automated message from the Apache Git Service.
To
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1614781080
> I dont have such a line in that file
Look at the lines explained in the errors . Unfortunately Sphinx is not
exactly known from providing vey helpful error messages - but
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1614689585
> @potiuk I won't be able to contribute any more than this, unfortunately.
This PR also dragged on too long(passed the 1 year mark) and it is hard to keep
track of the changes in the
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1614446511
> Hi folks! I maintain the flux operator and a few others that launch HPC
schedulers as Kubernetes Jobs (Indexed and Jobset) and this caught my eye
because we'd like to try launching,
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1613446308
docs errors :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1605071290
errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1602547577
> Any news regarding the status of this PR? Thanks!
I think everything is here - re status. This is why we have all the
information in the PR. look at teh status of the tests and
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1549474183
Unfortunately - there is a conflict in the meantime.
We are also reworking slightly some deprecation mechanism and the way how
KubernetesOperator uses hooks, so I think it's best
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1537339776
Can you rebase it first @hamedhsn - I will take a look after you do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1385024729
I think @hamedhsn it would be great to rebase firsst and make sure all tests
are passing. It makes little sense to review code when the tests are "red" -
including static checks, docs
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1366167956
Are you still going to work on it @hamedhsn ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1159812854
Far beyond my understanding of how K8S operators work internally. I am
afraid more thorough review of @dstandish , @jedcunningham or @ephraimbuddy or
even @dimberman would be needed.
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1117936060
@hamedhsn - first of all : rebase (it has conflicts now). Secondly - make
sure that all checks pass. Then ping us.
--
This is an automated message from the Apache Git Service.
To
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1108432770
> @potiuk what you are talking about is code sharing, provider depending on
code in core, having deps intermixed with core deps. but just because the
operator depends on core doesn't
potiuk commented on PR #22253:
URL: https://github.com/apache/airflow/pull/22253#issuecomment-1096643179
@dstandish - this is yet another example and contribution to the discussion
we have here: https://lists.apache.org/thread/m40ljkgcqsnvbxz6vlgnwflygvr6vznz
The change here spans
16 matches
Mail list logo
