potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1656578484
> Okay, I'll try whip this up today. What message should we add in the
AirflowOptionalProviderFeatureException? Or is this really only for our import
checks and is unlikely to be hit by
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1656576150
Fantastic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1656188970
BTW. I really like how it makes the core even more "lean" without provider's
discovery. That's really good observation that we ONLY need chosen executor's
command set and "other's" are
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1656177698
Added my comments - looks good, but I think we should slightly improve
diagnostics of problems and typing hints.
--
This is an automated message from the Apache Git Service.
To
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1605060078
> This is still blocked by #30727 waiting for a merge of that one
Maybe good time to merge it.
--
This is an automated message from the Apache Git Service.
To respond to the
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1480004738
> Thanks @potiuk, I'll rebase now.
>
> I have also noticed that since we now load the executors to retrieve CLI
commands which they want to vend, it does slow down the time it
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1479699380
You can rebase now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1479638800
Fix to failing tests (I think) in
https://github.com/apache/airflow/pull/29608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1479426300
I looked at the "Wait for prod images" change and I think this change
triggers a very subtle error @o-nikolas
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1459082234
> I had already started pulling out the commit which refactors cli_parser.py
into it's own PR which can be reviewed here
https://github.com/apache/airflow/pull/29962
Cool. Let's
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1458933429
Go ahead I think @o-nikolas :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1454837988
BTW. It's ok to merge it as a single squashed PR I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on PR #29055:
URL: https://github.com/apache/airflow/pull/29055#issuecomment-1435668326
(sorry for looong delay). Yes. All that is cool - and I think we should
simply split it into three PRs to do a final review :)
--
This is an automated message from the Apache Git
13 matches
Mail list logo
