[GitHub] [airflow] potiuk commented on pull request #31920: Deprecate the 2 non-official elasticsearch libraries

2023-06-23 Thread via GitHub
potiuk commented on PR #31920: URL: https://github.com/apache/airflow/pull/31920#issuecomment-1605076347 Woooho! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #31920: Deprecate the 2 non-official elasticsearch libraries

2023-06-23 Thread via GitHub
potiuk commented on PR #31920: URL: https://github.com/apache/airflow/pull/31920#issuecomment-1604386631 > @potiuk The CI job `provider package wheel (verify)` is still failing : > > ```shell > fatal: bad revision 'apache-https-for-providers/main...providers-elasticsearch/4.5.1'

[GitHub] [airflow] potiuk commented on pull request #31920: Deprecate the 2 non-official elasticsearch libraries

2023-06-22 Thread via GitHub
potiuk commented on PR #31920: URL: https://github.com/apache/airflow/pull/31920#issuecomment-1603244546 Can you rebase @Owen-CH-Leung ? We had some issues with building images that need rebase -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] potiuk commented on pull request #31920: Deprecate the 2 non-official elasticsearch libraries

2023-06-15 Thread via GitHub
potiuk commented on PR #31920: URL: https://github.com/apache/airflow/pull/31920#issuecomment-1592893029 > If we can split this PR int 2: core part and provider part that would be better as providers and core don't have same release cycle Oh yeah. I am curious how it will work out to

[GitHub] [airflow] potiuk commented on pull request #31920: Deprecate the 2 non-official elasticsearch libraries

2023-06-15 Thread via GitHub
potiuk commented on PR #31920: URL: https://github.com/apache/airflow/pull/31920#issuecomment-1592726301 cc: @eladkal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on pull request #31920: Deprecate the 2 non-official elasticsearch libraries

2023-06-15 Thread via GitHub
potiuk commented on PR #31920: URL: https://github.com/apache/airflow/pull/31920#issuecomment-1592725217 Looks fantastic. Will open up for Elasticsearch 8 migration. What we will also need is a note in the elasticsearch Changelog.rst and bumping the version there (and in