pateash commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2094924733
@eladkal what do we think?
1. I think as suggested by @shubham22,
we can make this as consistent( allowing drainage by default )
2. Or by adding an argument to DAG()
shubham22 commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2092464893
I agree with @jscheffl here that this use case doesn't warrant adding a new
state with paused/unpaused/drain for DAGs as it will complicate and slow down
scheduling (and
SangwanP commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2089068306
I have an alternative solution; someone with a deeper knowledge of the code
base can evaluate it:
If one is able to 'disable' the schedule on a DAG, the 'drain' functionality
eladkal commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-209489
@jscheffl The way I imagine it is that the drain status is temporary (for
the duration of the drain). once drain is finished it should be switched to
pause. So at any given time
jscheffl commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-200568
I feel linke when going into details of database, DAG model, REST API,
CLI... UI Experience this is a very complex thing. I agree that this option is
useful.
On the other hand
eladkal commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2088864728
I prefer option 1.
We need to remember that pausing DAG can also be done from API/CLI and not
just the UI.
We can simply deprecate `is_paused_upon_creation` and replace it
pateash commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2081502759
> I am OK with having some code settings that can help limit the pausing
options on specific dag (should DAG author wants it) but as a general concept I
don't think it should be
eladkal commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2081357890
I am OK with having some code settings that can help limit the pausing
options but as a general concept I don't think it should be government by code.
Today you can
pateash commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2080376908
thanks @bbovenzi,
I have found a way to still complete the DAGRun, even if the dag is paused.
Do we want it to be default behaviour of we should parameterize it with an
bbovenzi commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2010271699
Instead of messing with the state, I wonder if we could have an advanced
version of the dag pause action. That will pause a dag after the end of the run.
We already have a
pateash commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2009333587
Can We change schema of DAG(),
is_paused should be having same datatype in both DagModel and Dag,
changing it from boolean to string will also change openAPI spec and so on.
pateash commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2009219812
Going with Option(2)
paused: states ( PAUSED, DRAIN) ~ Anything not UNPAUSED
unpaused: state( UNPAUSED)
--
This is an automated message from the Apache Git Service.
To
pateash commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2009168965
I am happy to check this out,
IMO changing "is_paused" from boolean to string( paused/unpaused/drain )
could be a good idea in DAGModel,
without changing it for the user
13 matches
Mail list logo
