[
https://issues.apache.org/jira/browse/AIRFLOW-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579275#comment-16579275
]
ASF GitHub Bot commented on AIRFLOW-491:
xnuinside opened a new pull request #37
xnuinside opened a new pull request #3733: [WIP] [AIRFLOW-491] Add cache
parameter in BigQuery query method
URL: https://github.com/apache/incubator-airflow/pull/3733
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](htt
[
https://issues.apache.org/jira/browse/AIRFLOW-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579274#comment-16579274
]
ASF GitHub Bot commented on AIRFLOW-491:
xnuinside closed pull request #3733: [W
xnuinside closed pull request #3733: [WIP] [AIRFLOW-491] Add cache parameter in
BigQuery query method
URL: https://github.com/apache/incubator-airflow/pull/3733
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412697854
Hi @feng-tao , I agree that PRs #3651 and #3729 must be reverted as they
are causing CSRF issues in web UI at this moment(they
XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412697854
Hi @feng-tao , I agree that PRs #3651 and #3729 must be reverted as they
are causing CSRF issues in web UI at this moment(they
fenglu-g edited a comment on issue #3744: [AIRFLOW-2893] fix stuck dataflow job
due to name mismatch
URL:
https://github.com/apache/incubator-airflow/pull/3744#issuecomment-412741886
@kaxil @TrevorEdwards replied to your comments, PTAL.
---
fenglu-g commented on issue #3744: [AIRFLOW-2893] fix stuck dataflow job due to
name mismatch
URL:
https://github.com/apache/incubator-airflow/pull/3744#issuecomment-412741886
@kaxil @TrevorEdwards replied to both of your comments, PTAL.
--
codecov-io commented on issue #3744: [AIRFLOW-2893] fix stuck dataflow job due
to name mismatch
URL:
https://github.com/apache/incubator-airflow/pull/3744#issuecomment-412739331
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3744?src=pr&el=h1)
Report
> Merging
[#3744
fenglu-g commented on a change in pull request #3744: [AIRFLOW-2893] fix stuck
dataflow job due to name mismatch
URL: https://github.com/apache/incubator-airflow/pull/3744#discussion_r209797532
##
File path: airflow/contrib/hooks/gcp_dataflow_hook.py
##
@@ -124,36 +127,38
fenglu-g commented on a change in pull request #3744: [AIRFLOW-2893] fix stuck
dataflow job due to name mismatch
URL: https://github.com/apache/incubator-airflow/pull/3744#discussion_r209797314
##
File path: airflow/contrib/hooks/gcp_dataflow_hook.py
##
@@ -124,36 +127,38
XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412697854
Hi @feng-tao , I agree that PRs #3651 and #3729 must be reverted as they
are causing CSRF issues in web UI at this moment(they
r39132 commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue
URL:
https://github.com/apache/incubator-airflow/pull/3724#issuecomment-412700876
@verdan thx for catching this.. @feng-tao thx for executing the reversion.
@verdan Can we add a test to catch this next time?
XD-DENG commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412697854
Hi @feng-tao , I agree that PRs #3651 and #3729 must be reverted as they
are causing CSRF issues in web UI (they are also reverts in
TrevorEdwards commented on a change in pull request #3744: [AIRFLOW-2893] fix
stuck dataflow job due to name mismatch
URL: https://github.com/apache/incubator-airflow/pull/3744#discussion_r209788007
##
File path: airflow/contrib/hooks/gcp_dataflow_hook.py
##
@@ -124,36 +12
TrevorEdwards commented on a change in pull request #3744: [AIRFLOW-2893] fix
stuck dataflow job due to name mismatch
URL: https://github.com/apache/incubator-airflow/pull/3744#discussion_r209787554
##
File path: airflow/contrib/hooks/gcp_dataflow_hook.py
##
@@ -124,36 +12
TrevorEdwards commented on a change in pull request #3744: [AIRFLOW-2893] fix
stuck dataflow job due to name mismatch
URL: https://github.com/apache/incubator-airflow/pull/3744#discussion_r209786479
##
File path: airflow/contrib/hooks/gcp_dataflow_hook.py
##
@@ -124,36 +12
Noremac201 edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask
SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412691372
As far as I can tell, I can't save any passwords in Connections in Airflow
webUI from a fresh master and this commit cherry-
Noremac201 commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412691372
As far as I can tell, I can't save any passwords in Connections in Airflow
webUI from a fresh master and this commit cherry-picked.
codecov-io commented on issue #3747: [AIRFLOW-2895] Prevent scheduler from
spamming heartbeats/logs
URL:
https://github.com/apache/incubator-airflow/pull/3747#issuecomment-412669040
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3747?src=pr&el=h1)
Report
> Merging
[#
aoen commented on a change in pull request #3747: [AIRFLOW-2895] Prevent
scheduler from spamming heartbeats/logs
URL: https://github.com/apache/incubator-airflow/pull/3747#discussion_r209744335
##
File path: UPDATING.md
##
@@ -420,10 +420,6 @@ indefinitely. This is only av
yrqls21 edited a comment on issue #2986: [AIRFLOW-2027] Only trigger sleep in
scheduler after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412637527
@aoen
Agree on sleep for a minimal time interval(max(0, 1s-duration)), it should
not be
yrqls21 commented on issue #2986: [AIRFLOW-2027] Only trigger sleep in
scheduler after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412637527
@aoen
Agree on sleep for a minimal time interval, it should not be a huge problem
to sleep at
kaxil commented on a change in pull request #3725: [AIRFLOW-2877] Make docs
site URL consistent everywhere
URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209730842
##
File path: README.md
##
@@ -24,9 +24,9 @@ monitor progress, and troubleshoot issue
tedmiston commented on a change in pull request #3725: [AIRFLOW-2877] Make docs
site URL consistent everywhere
URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209729859
##
File path: README.md
##
@@ -24,9 +24,9 @@ monitor progress, and troubleshoot i
tedmiston commented on a change in pull request #3725: [AIRFLOW-2877] Make docs
site URL consistent everywhere
URL: https://github.com/apache/incubator-airflow/pull/3725#discussion_r209729859
##
File path: README.md
##
@@ -24,9 +24,9 @@ monitor progress, and troubleshoot i
Cameron Moberg created AIRFLOW-2897:
---
Summary: GKEPodOperator not deleting service account file after
done with it
Key: AIRFLOW-2897
URL: https://issues.apache.org/jira/browse/AIRFLOW-2897
Project:
feng-tao commented on a change in pull request #3747: [AIRFLOW-2895] Prevent
scheduler from spamming heartbeats/logs
URL: https://github.com/apache/incubator-airflow/pull/3747#discussion_r209707193
##
File path: UPDATING.md
##
@@ -420,10 +420,6 @@ indefinitely. This is onl
Fokko commented on issue #3745: [AIRFLOW-2860] DruidHook: time check is wrong
URL:
https://github.com/apache/incubator-airflow/pull/3745#issuecomment-412612939
Thanks again @awelsh93
This is an automated message from the Apa
[
https://issues.apache.org/jira/browse/AIRFLOW-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578723#comment-16578723
]
ASF GitHub Bot commented on AIRFLOW-2895:
-
aoen opened a new pull request #3747
feng-tao edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412609075
This pr currently can't address the issue when we have a cluster for
webserver. IMO, I would prefer to revert the orignal prs a
feng-tao edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412609075
This pr currently can't address the issue when we have a cluster for
webserver. IMO, I would prefer to revert the orignal prs a
TrevorEdwards commented on a change in pull request #3532: [AIRFLOW-2658] Add
GCP specific k8s pod operator
URL: https://github.com/apache/incubator-airflow/pull/3532#discussion_r209703493
##
File path: airflow/contrib/operators/gcp_container_operator.py
##
@@ -170,3 +175,
aoen opened a new pull request #3747: [AIRFLOW-2895] Prevent scheduler from
spamming heartbeats/logs
URL: https://github.com/apache/incubator-airflow/pull/3747
Reverts most of AIRFLOW-2027 until the issues with it can be fixed.
### Jira
- [X] My PR addresses the following [Air
feng-tao edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412608140
looking at this https://github.com/apache/incubator-airflow/pull/3651 pr, I
am wondering whether we could do better than use ra
feng-tao edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412608140
looking at this https://github.com/apache/incubator-airflow/pull/3651 pr, I
am wondering whether we could do better than use ra
feng-tao commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412609075
IMO, I would prefer to revert the orignal prs and improve the secret_key
config documentation.
--
feng-tao edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412608140
looking at this https://github.com/apache/incubator-airflow/pull/3651 pr, I
am wondering whether we could do better than use ra
feng-tao commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412608140
looking at this https://github.com/apache/incubator-airflow/pull/3651 pr, I
am wondering whether we could do better than use random fu
[
https://issues.apache.org/jira/browse/AIRFLOW-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578708#comment-16578708
]
Taylor Edmiston commented on AIRFLOW-2844:
--
[~Kyle Bridenstine] Given your ans
[
https://issues.apache.org/jira/browse/AIRFLOW-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578597#comment-16578597
]
ASF subversion and git services commented on AIRFLOW-2860:
--
Co
[
https://issues.apache.org/jira/browse/AIRFLOW-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578596#comment-16578596
]
ASF GitHub Bot commented on AIRFLOW-2860:
-
feng-tao closed pull request #3745:
feng-tao closed pull request #3745: [AIRFLOW-2860] DruidHook: time check is
wrong
URL: https://github.com/apache/incubator-airflow/pull/3745
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
feng-tao commented on issue #3745: [AIRFLOW-2860] DruidHook: time check is wrong
URL:
https://github.com/apache/incubator-airflow/pull/3745#issuecomment-412583545
lgtm.
This is an automated message from the Apache Git Service
[
https://issues.apache.org/jira/browse/AIRFLOW-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578536#comment-16578536
]
Brian Hann commented on AIRFLOW-184:
{quote}Is this issue still relevant?
{quote}
Ye
kaxil commented on a change in pull request #3744: [AIRFLOW-2893] fix stuck
dataflow job due to name mismatch
URL: https://github.com/apache/incubator-airflow/pull/3744#discussion_r209652868
##
File path: tests/contrib/hooks/test_gcp_dataflow_hook.py
##
@@ -24,6 +24,7 @@
kaxil commented on issue #3744: [AIRFLOW-2893] fix stuck dataflow job due to
name mismatch
URL:
https://github.com/apache/incubator-airflow/pull/3744#issuecomment-412558011
@fenglu-g Looks like a Python 3 test failures:
```
fenglu-g commented on issue #3744: [AIRFLOW-2893] fix stuck dataflow job due to
name mismatch
URL:
https://github.com/apache/incubator-airflow/pull/3744#issuecomment-412547321
@kaxil @Fokko PTAL, thanks.
Travis run results seem wrong as the error message is irrelevant, but will
see ho
codecov-io commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL:
https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412545983
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3738?src=pr&el=h1)
Report
> Merging
[#3738](https://codecov.io/
[
https://issues.apache.org/jira/browse/AIRFLOW-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578350#comment-16578350
]
ASF GitHub Bot commented on AIRFLOW-2896:
-
XD-DENG opened a new pull request #3
XD-DENG opened a new pull request #3746: [AIRFLOW-2896] Improve HdfsSensor()
URL: https://github.com/apache/incubator-airflow/pull/3746
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/brow
Xiaodong DENG created AIRFLOW-2896:
--
Summary: Improve HdfsSensor()
Key: AIRFLOW-2896
URL: https://issues.apache.org/jira/browse/AIRFLOW-2896
Project: Apache Airflow
Issue Type: Improvement
aoen commented on issue #2986: [AIRFLOW-2027] Only trigger sleep in scheduler
after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412527370
Ah I missed that, would be for 1.10.1 then, yeah.
---
bolkedebruin commented on issue #2986: [AIRFLOW-2027] Only trigger sleep in
scheduler after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412526671
K... but I assume "unblocking" means 1.10.1 not 1.10.0 as the vote has
already passed?
-
aoen edited a comment on issue #2986: [AIRFLOW-2027] Only trigger sleep in
scheduler after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412526097
This bug can cause severe issues if the particular edge cases are hit, I
guess no one reported
aoen commented on issue #2986: [AIRFLOW-2027] Only trigger sleep in scheduler
after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412526097
This bug can cause severe issues if the particular use cases are hit, I
guess no one reported it in t
bolkedebruin commented on issue #2986: [AIRFLOW-2027] Only trigger sleep in
scheduler after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412525557
@aoen unblock release? I don't follow?
--
Dan Davydov created AIRFLOW-2895:
Summary: Prevent scheduler from spamming heartbeats/logs
Key: AIRFLOW-2895
URL: https://issues.apache.org/jira/browse/AIRFLOW-2895
Project: Apache Airflow
Is
aoen edited a comment on issue #2986: [AIRFLOW-2027] Only trigger sleep in
scheduler after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412524787
There seems to be a couple of problems that cause the sleep to not trigger
and Scheduler heart
aoen commented on issue #2986: [AIRFLOW-2027] Only trigger sleep in scheduler
after all files have parsed
URL:
https://github.com/apache/incubator-airflow/pull/2986#issuecomment-412524787
There seems to be a couple of problems:
1. If the number of files (can be fixed by sleeping for min
codecov-io commented on issue #3745: [AIRFLOW-2860] DruidHook: time check is
wrong
URL:
https://github.com/apache/incubator-airflow/pull/3745#issuecomment-412520688
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3745?src=pr&el=h1)
Report
> Merging
[#3745](https://cod
bolkedebruin commented on issue #3740: [AIRFLOW-2888] Remove shell=True and
bash from task launch
URL:
https://github.com/apache/incubator-airflow/pull/3740#issuecomment-412515522
@dimberman ready for testing
This is an auto
codecov-io commented on issue #3740: [AIRFLOW-2888] Remove shell=True and bash
from task launch
URL:
https://github.com/apache/incubator-airflow/pull/3740#issuecomment-412510607
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3740?src=pr&el=h1)
Report
> Merging
[#3740
[
https://issues.apache.org/jira/browse/AIRFLOW-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578250#comment-16578250
]
ASF GitHub Bot commented on AIRFLOW-2860:
-
awelsh93 opened a new pull request #
awelsh93 opened a new pull request #3745: [AIRFLOW-2860] DruidHook: time check
is wrong
URL: https://github.com/apache/incubator-airflow/pull/3745
### Jira
- [x] My PR addresses the following
[Airflow-2860](https://issues.apache.org/jira/browse/AIRFLOW-2860) issues and
references t
codecov-io edited a comment on issue #3741: [AIRFLOW-1368] Add auto_remove for
DockerOperator
URL:
https://github.com/apache/incubator-airflow/pull/3741#issuecomment-412492251
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3741?src=pr&el=h1)
Report
> Merging
[#3741](
codecov-io commented on issue #3741: [AIRFLOW-1368] Add auto_remove for
DockerOperator
URL:
https://github.com/apache/incubator-airflow/pull/3741#issuecomment-412492251
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3741?src=pr&el=h1)
Report
> Merging
[#3741](https:/
Wouter-M commented on issue #3741: [AIRFLOW-1368] Add auto_remove for
DockerOperator
URL:
https://github.com/apache/incubator-airflow/pull/3741#issuecomment-412484573
Hey @Fokko! Long time no see indeed. :)
I added the requested change.
Fokko commented on a change in pull request #3393: [AIRFLOW-2499] Dockerised CI
pipeline
URL: https://github.com/apache/incubator-airflow/pull/3393#discussion_r209530764
##
File path: .travis.yml
##
@@ -19,94 +19,39 @@
sudo: true
dist: trusty
language: python
-jdk:
- -
Fokko commented on a change in pull request #3393: [AIRFLOW-2499] Dockerised CI
pipeline
URL: https://github.com/apache/incubator-airflow/pull/3393#discussion_r209530471
##
File path: .travis.yml
##
@@ -19,94 +19,39 @@
sudo: true
dist: trusty
language: python
-jdk:
- -
Fokko commented on a change in pull request #3393: [AIRFLOW-2499] Dockerised CI
pipeline
URL: https://github.com/apache/incubator-airflow/pull/3393#discussion_r209531199
##
File path: scripts/ci/docker-compose.yml
##
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software F
Fokko commented on issue #3393: [AIRFLOW-2499] Dockerised CI pipeline
URL:
https://github.com/apache/incubator-airflow/pull/3393#issuecomment-412446782
Hi @gerardo, I really appreciate the effort that you're putting into this. I
think the last step is creating the `incubator-airflow-ci` re
[
https://issues.apache.org/jira/browse/AIRFLOW-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577938#comment-16577938
]
ASF GitHub Bot commented on AIRFLOW-2893:
-
fenglu-g opened a new pull request #
fenglu-g opened a new pull request #3744: [AIRFLOW-2893] fix stuck dataflow job
due to name mismatch
URL: https://github.com/apache/incubator-airflow/pull/3744
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://is
gerardo commented on issue #3393: [AIRFLOW-2499] Dockerised CI pipeline
URL:
https://github.com/apache/incubator-airflow/pull/3393#issuecomment-412434714
Hi @Fokko @dimberman @bolkedebruin. I'm following up on this PR. What else
do you think needs to be fixed before merging this PR?
75 matches
Mail list logo
