[jira] [Commented] (AIRFLOW-3264) Only '/' is URL-decoded when parsing hostname in the Connection

2018-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1764#comment-1764 ] ASF GitHub Bot commented on AIRFLOW-3264: - jghoman closed pull request #4109: [

[GitHub] jghoman commented on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
jghoman commented on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109#issuecomment-433793757 Thanks. Merging. This is an automated message f

[GitHub] jghoman closed pull request #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
jghoman closed pull request #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] KimchaC commented on issue #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-28 Thread GitBox
KimchaC commented on issue #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#issuecomment-433792007 One more thing to consider... I noticed the start date is set in the default args. Isn’t that legacy? Since the start_date has no

[GitHub] phani8996 commented on issue #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log

2018-10-28 Thread GitBox
phani8996 commented on issue #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log URL: https://github.com/apache/incubator-airflow/pull/3992#issuecomment-433782700 > @phani8996 Can you rebase onto master? To make sure that you're up to date. It i

[jira] [Issue Comment Deleted] (AIRFLOW-2490) Add delete_dag for CLI

2018-10-28 Thread honglichang (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] honglichang updated AIRFLOW-2490: - Comment: was deleted (was: delete dag by CLI, also left dag record at dag table,  and grey dag

[jira] [Commented] (AIRFLOW-2490) Add delete_dag for CLI

2018-10-28 Thread honglichang (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1710#comment-1710 ] honglichang commented on AIRFLOW-2490: -- delete dag by CLI, also left dag record at

[GitHub] codecov-io edited a comment on issue #4069: [AIRFLOW-3233] Fix deletion of DAGs in the UI

2018-10-28 Thread GitBox
codecov-io edited a comment on issue #4069: [AIRFLOW-3233] Fix deletion of DAGs in the UI URL: https://github.com/apache/incubator-airflow/pull/4069#issuecomment-431490567 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4069?src=pr&el=h1) Report > Merging [#4069](http

[GitHub] mikemole commented on issue #4112: [AIRFLOW-3212] Add AwsGlueCatalogPartitionSensor

2018-10-28 Thread GitBox
mikemole commented on issue #4112: [AIRFLOW-3212] Add AwsGlueCatalogPartitionSensor URL: https://github.com/apache/incubator-airflow/pull/4112#issuecomment-433755710 It looks like I still need to generate the API docs, but I can' find any instructions on how to do it. Can someone point m

[jira] [Commented] (AIRFLOW-3212) Add AWS Glue Catalog sensor like HivePartitionSensor

2018-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1607#comment-1607 ] ASF GitHub Bot commented on AIRFLOW-3212: - mikemole opened a new pull request #

[GitHub] mikemole opened a new pull request #4112: [AIRFLOW-3212] Add AwsGlueCatalogPartitionSensor

2018-10-28 Thread GitBox
mikemole opened a new pull request #4112: [AIRFLOW-3212] Add AwsGlueCatalogPartitionSensor URL: https://github.com/apache/incubator-airflow/pull/4112 Adds AwsGlueCatalogPartitionSensor and AwsGlueCatalogHook with supporting functions. Unit tests are included but rely on mocking since

[GitHub] potiuk commented on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
potiuk commented on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109#issuecomment-433750911 @Fokko - Fixed! It's good to have such comprehensive test suite! It actually caught an error with no password conn

[GitHub] codecov-io edited a comment on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
codecov-io edited a comment on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109#issuecomment-433750759 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4109?src=pr&el=h1) Report > Merging

[GitHub] codecov-io commented on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
codecov-io commented on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109#issuecomment-433750759 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4109?src=pr&el=h1) Report > Merging [#410

[GitHub] Fokko commented on issue #4102: [AIRFLOW-3262] Add param to log response when using SimpleHttpOperator

2018-10-28 Thread GitBox
Fokko commented on issue #4102: [AIRFLOW-3262] Add param to log response when using SimpleHttpOperator URL: https://github.com/apache/incubator-airflow/pull/4102#issuecomment-433729909 Maybe add a test? It is easy to http get a page of Airflow itself, and check if it shows up in the log :

[GitHub] Fokko commented on issue #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log

2018-10-28 Thread GitBox
Fokko commented on issue #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log URL: https://github.com/apache/incubator-airflow/pull/3992#issuecomment-433729693 @phani8996 Can you rebase onto master? To make sure that you're up to date.

[GitHub] Fokko edited a comment on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
Fokko edited a comment on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109#issuecomment-433729528 The PR looks conceptually good to me. @potiuk Can you fix the CI? --

[GitHub] Fokko commented on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
Fokko commented on issue #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109#issuecomment-433729528 @potiuk Can you fix the CI? This is an automated m

[GitHub] Fokko commented on a change in pull request #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
Fokko commented on a change in pull request #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109#discussion_r228759216 ## File path: airflow/models.py ## @@ -808,6 +808,17 @@ def get_hook(self):

[jira] [Commented] (AIRFLOW-3265) Mysql Hook does not support "unix_socket" extra

2018-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1513#comment-1513 ] ASF GitHub Bot commented on AIRFLOW-3265: - Fokko closed pull request #4110: [AI

[GitHub] Fokko closed pull request #4110: [AIRFLOW-3265] Support for "unix_socket" extra for MySQL hook

2018-10-28 Thread GitBox
Fokko closed pull request #4110: [AIRFLOW-3265] Support for "unix_socket" extra for MySQL hook URL: https://github.com/apache/incubator-airflow/pull/4110 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[jira] [Resolved] (AIRFLOW-3265) Mysql Hook does not support "unix_socket" extra

2018-10-28 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-3265. --- Resolution: Fixed Fix Version/s: 2.0.0 > Mysql Hook does not support "unix_s

[GitHub] phani8996 commented on issue #4111: [AIRFLOW-3266] AWS Athena Operator and hook created

2018-10-28 Thread GitBox
phani8996 commented on issue #4111: [AIRFLOW-3266] AWS Athena Operator and hook created URL: https://github.com/apache/incubator-airflow/pull/4111#issuecomment-433727992 > I'm probably not the best person to review this, having no experience with AWS, but one suggestion is adding some doc

[GitHub] jeffkpayne commented on issue #4111: [AIRFLOW-3266] AWS Athena Operator and hook created

2018-10-28 Thread GitBox
jeffkpayne commented on issue #4111: [AIRFLOW-3266] AWS Athena Operator and hook created URL: https://github.com/apache/incubator-airflow/pull/4111#issuecomment-433727557 I'm probably not the best person to review this, having no experience with AWS, but one suggestion is adding some docs

[GitHub] codecov-io commented on issue #4111: [AIRFLOW-3266] AWS Athena Operator and hook created

2018-10-28 Thread GitBox
codecov-io commented on issue #4111: [AIRFLOW-3266] AWS Athena Operator and hook created URL: https://github.com/apache/incubator-airflow/pull/4111#issuecomment-433705746 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4111?src=pr&el=h1) Report > Merging [#4111](https

[GitHub] codecov-io commented on issue #4110: [AIRFLOW-3265] Support for "unix_socket" extra for MySQL hook

2018-10-28 Thread GitBox
codecov-io commented on issue #4110: [AIRFLOW-3265] Support for "unix_socket" extra for MySQL hook URL: https://github.com/apache/incubator-airflow/pull/4110#issuecomment-433698165 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4110?src=pr&el=h1) Report > Merging [#4

[jira] [Comment Edited] (AIRFLOW-3239) Test discovery partial fails due to incorrect name of the test files

2018-10-28 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1278#comment-1278 ] Xiaodong DENG edited comment on AIRFLOW-3239 at 10/28/18 10:47 AM: --

[jira] [Comment Edited] (AIRFLOW-3239) Test discovery partial fails due to incorrect name of the test files

2018-10-28 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1278#comment-1278 ] Xiaodong DENG edited comment on AIRFLOW-3239 at 10/28/18 10:47 AM: --

[jira] [Commented] (AIRFLOW-1079) Dag is still visible in ui, after removing it from the dag folder

2018-10-28 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1347#comment-1347 ] jack commented on AIRFLOW-1079: --- Deleting the DAG file manually doesn't delete it from th

[jira] [Commented] (AIRFLOW-3266) AWS Athena Operator in Airflow

2018-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1346#comment-1346 ] ASF GitHub Bot commented on AIRFLOW-3266: - phani8996 opened a new pull request

[GitHub] phani8996 opened a new pull request #4111: [AIRFLOW-3266] AWS Athena Operator and hook created

2018-10-28 Thread GitBox
phani8996 opened a new pull request #4111: [AIRFLOW-3266] AWS Athena Operator and hook created URL: https://github.com/apache/incubator-airflow/pull/4111 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references th

[jira] [Updated] (AIRFLOW-3266) AWS Athena Operator in Airflow

2018-10-28 Thread Sai Phanindhra (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Phanindhra updated AIRFLOW-3266: Description: There is no official athena operator as of now airflow. Either one has do it

[GitHub] ron819 commented on issue #3101: AIRFLOW-2179: Make parametrable the IP on which the worker log server binds to

2018-10-28 Thread GitBox
ron819 commented on issue #3101: AIRFLOW-2179: Make parametrable the IP on which the worker log server binds to URL: https://github.com/apache/incubator-airflow/pull/3101#issuecomment-433691495 @AlbinOS ping This is an autom

[jira] [Commented] (AIRFLOW-351) Failed to clear downstream tasks

2018-10-28 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1344#comment-1344 ] jack commented on AIRFLOW-351: -- There seems to be an open (old) PR for this which isn't lis

[jira] [Updated] (AIRFLOW-3266) AWS Athena Operator in Airflow

2018-10-28 Thread Sai Phanindhra (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Phanindhra updated AIRFLOW-3266: Description: These is no official athena operator as of now airflow. Either one has do it

[jira] [Created] (AIRFLOW-3266) AWS Athena Operator in Airflow

2018-10-28 Thread Sai Phanindhra (JIRA)
Sai Phanindhra created AIRFLOW-3266: --- Summary: AWS Athena Operator in Airflow Key: AIRFLOW-3266 URL: https://issues.apache.org/jira/browse/AIRFLOW-3266 Project: Apache Airflow Issue Type: N

[GitHub] phani8996 commented on issue #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log

2018-10-28 Thread GitBox
phani8996 commented on issue #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log URL: https://github.com/apache/incubator-airflow/pull/3992#issuecomment-433691037 Tests seems to be failing at places unrelated to my code changes. Do anyone has any idea

[GitHub] ron819 commented on issue #3453: [AIRFLOW-2554] Enable convenience access to in/outlets in templates

2018-10-28 Thread GitBox
ron819 commented on issue #3453: [AIRFLOW-2554] Enable convenience access to in/outlets in templates URL: https://github.com/apache/incubator-airflow/pull/3453#issuecomment-433690738 @bolkedebruin any progress with that? Th

[jira] [Commented] (AIRFLOW-2925) gcp dataflow hook doesn't show traceback

2018-10-28 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1334#comment-1334 ] jack commented on AIRFLOW-2925: --- [~xnuinside] correct me if I'm wrong but when raise Exce

[GitHub] codecov-io edited a comment on issue #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job

2018-10-28 Thread GitBox
codecov-io edited a comment on issue #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job URL: https://github.com/apache/incubator-airflow/pull/4108#issuecomment-433685129 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4108?src=pr&el=h1) Rep

[jira] [Commented] (AIRFLOW-3265) Mysql Hook does not support "unix_socket" extra

2018-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1324#comment-1324 ] ASF GitHub Bot commented on AIRFLOW-3265: - potiuk opened a new pull request #41

[GitHub] codecov-io commented on issue #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job

2018-10-28 Thread GitBox
codecov-io commented on issue #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job URL: https://github.com/apache/incubator-airflow/pull/4108#issuecomment-433685129 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4108?src=pr&el=h1) Report

[GitHub] potiuk opened a new pull request #4110: [AIRFLOW-3265] Support for "unix_socket" extra for MySQL hook

2018-10-28 Thread GitBox
potiuk opened a new pull request #4110: [AIRFLOW-3265] Support for "unix_socket" extra for MySQL hook URL: https://github.com/apache/incubator-airflow/pull/4110 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://i

[jira] [Commented] (AIRFLOW-3264) Only '/' is URL-decoded when parsing hostname in the Connection

2018-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1322#comment-1322 ] ASF GitHub Bot commented on AIRFLOW-3264: - potiuk opened a new pull request #41

[GitHub] potiuk opened a new pull request #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection

2018-10-28 Thread GitBox
potiuk opened a new pull request #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://iss

[jira] [Commented] (AIRFLOW-3263) CLI 'run' method sometimes exits with error when there is a race on killing airflow job

2018-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1318#comment-1318 ] ASF GitHub Bot commented on AIRFLOW-3263: - potiuk opened a new pull request #41

[GitHub] potiuk opened a new pull request #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job

2018-10-28 Thread GitBox
potiuk opened a new pull request #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job URL: https://github.com/apache/incubator-airflow/pull/4108 Sometimes when you run tasks from command line you get exit code = 1 due to race condition (job runner tries to g

[jira] [Assigned] (AIRFLOW-3265) Mysql Hook does not support "unix_socket" extra

2018-10-28 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk reassigned AIRFLOW-3265: - Assignee: Jarek Potiuk > Mysql Hook does not support "unix_socket" extra > ---

[jira] [Created] (AIRFLOW-3265) Mysql Hook does not support "unix_socket" extra

2018-10-28 Thread Jarek Potiuk (JIRA)
Jarek Potiuk created AIRFLOW-3265: - Summary: Mysql Hook does not support "unix_socket" extra Key: AIRFLOW-3265 URL: https://issues.apache.org/jira/browse/AIRFLOW-3265 Project: Apache Airflow

[jira] [Assigned] (AIRFLOW-3264) Only '/' is URL-decoded when parsing hostname in the Connection

2018-10-28 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk reassigned AIRFLOW-3264: - Assignee: Jarek Potiuk > Only '/' is URL-decoded when parsing hostname in the Connecti

[jira] [Created] (AIRFLOW-3264) Only '/' is URL-decoded when parsing hostname in the Connection

2018-10-28 Thread Jarek Potiuk (JIRA)
Jarek Potiuk created AIRFLOW-3264: - Summary: Only '/' is URL-decoded when parsing hostname in the Connection Key: AIRFLOW-3264 URL: https://issues.apache.org/jira/browse/AIRFLOW-3264 Project: Apache A