[
https://issues.apache.org/jira/browse/AIRFLOW-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721012#comment-16721012
]
ASF GitHub Bot commented on AIRFLOW-3452:
-
feng-tao closed pull request #4295: AIRFLOW-3452
feng-tao closed pull request #4295: AIRFLOW-3452 removed an unused/dangerous
display-none
URL: https://github.com/apache/incubator-airflow/pull/4295
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
feng-tao commented on issue #4295: AIRFLOW-3452 removed an unused/dangerous
display-none
URL:
https://github.com/apache/incubator-airflow/pull/4295#issuecomment-447237713
lgtm. thanks @MarcusSorealheis
This is an automated
feng-tao removed a comment on issue #4312: AIRFLOW-3508: add slugify env to
build.sh script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-447216474
@eran-levy , please take a look at the release note for
feng-tao commented on issue #4312: AIRFLOW-3508: add slugify env to build.sh
script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-447216474
@eran-levy , please take a look at the release note for
eran-levy edited a comment on issue #4312: AIRFLOW-3508: add slugify env to
build.sh script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-447202253
@ashb
the kube tests are running fine because in travis this slugify env variable
is set, see logs:
eran-levy commented on issue #4312: AIRFLOW-3508: add slugify env to build.sh
script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-447202253
the kube tests are running fine because in travis this slugify env variable
is set, see logs:
_Setting environment
codecov-io edited a comment on issue #4225: [AIRFLOW-3383] Rotate fernet keys.
URL:
https://github.com/apache/incubator-airflow/pull/4225#issuecomment-441103479
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4225?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #4225: [AIRFLOW-3383] Rotate fernet keys.
URL:
https://github.com/apache/incubator-airflow/pull/4225#issuecomment-441103479
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4225?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #4225: [AIRFLOW-3383] Rotate fernet keys.
URL:
https://github.com/apache/incubator-airflow/pull/4225#issuecomment-441103479
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4225?src=pr=h1)
Report
> Merging
joyce chan created AIRFLOW-3514:
---
Summary: Documentation for run_query slightly off for bigquery_hook
Key: AIRFLOW-3514
URL: https://issues.apache.org/jira/browse/AIRFLOW-3514
Project: Apache Airflow
[
https://issues.apache.org/jira/browse/AIRFLOW-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720642#comment-16720642
]
Ash Berlin-Taylor commented on AIRFLOW-3513:
It is not clear what you are asking for here.
pakegecloud.atlassian.net created AIRFLOW-3513:
--
Summary: Pakegecloud
Key: AIRFLOW-3513
URL: https://issues.apache.org/jira/browse/AIRFLOW-3513
Project: Apache Airflow
Issue
ultrabug commented on issue #2455: [AIRFLOW-1423] Add logs to the scheduler DAG
run decision logic
URL:
https://github.com/apache/incubator-airflow/pull/2455#issuecomment-447116347
@ron819 well AFAIK I've done what has been asked for me but ofc now there
are conflicts..
I'd be
feng-tao commented on issue #4319: [AIRFLOW-2770] Read `dags_in_image` config
value as a boolean
URL:
https://github.com/apache/incubator-airflow/pull/4319#issuecomment-447114648
PTAL @dimberman
This is an automated
kppullin commented on issue #3683: [AIRFLOW-2770] kubernetes: add support for
dag folder in the docker i…
URL:
https://github.com/apache/incubator-airflow/pull/3683#issuecomment-447107253
PR #4319 fixes the issues with failing CI tests from this PR.
I do have one concern with the
ashb commented on issue #4318: Revert [AIRFLOW-2770] [AIRFLOW-3505]
URL:
https://github.com/apache/incubator-airflow/pull/4318#issuecomment-447098930
Thanks @feng-tao!
This is an automated message from the Apache Git
kppullin commented on a change in pull request #4319: [AIRFLOW-2770] Read
`dags_in_image` config value as a boolean
URL: https://github.com/apache/incubator-airflow/pull/4319#discussion_r241518434
##
File path: airflow/contrib/executors/kubernetes_executor.py
##
@@ -139,7
[
https://issues.apache.org/jira/browse/AIRFLOW-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720481#comment-16720481
]
ASF GitHub Bot commented on AIRFLOW-2770:
-
kppullin opened a new pull request #4319:
kppullin opened a new pull request #4319: [AIRFLOW-2770] Read `dags_in_image`
config value as a boolean
URL: https://github.com/apache/incubator-airflow/pull/4319
This PR is a minor fix for #3683
The `dags_in_image` config value is read as a string. However, the existing
code
[
https://issues.apache.org/jira/browse/AIRFLOW-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720460#comment-16720460
]
ASF GitHub Bot commented on AIRFLOW-2770:
-
feng-tao closed pull request #4318: Revert
feng-tao closed pull request #4318: Revert [AIRFLOW-2770] [AIRFLOW-3505]
URL: https://github.com/apache/incubator-airflow/pull/4318
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
codecov-io commented on issue #4318: Revert [AIRFLOW-2770] [AIRFLOW-3505]
URL:
https://github.com/apache/incubator-airflow/pull/4318#issuecomment-447069143
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4318?src=pr=h1)
Report
> Merging
[
https://issues.apache.org/jira/browse/AIRFLOW-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Pullin closed AIRFLOW-3501.
-
Resolution: Duplicate
> Add config option to load dags in an image with the kubernetes
[
https://issues.apache.org/jira/browse/AIRFLOW-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anonymous reassigned AIRFLOW-3501:
--
Assignee: Kevin Pullin
> Add config option to load dags in an image with the kubernetes
feng-tao commented on issue #3683: [AIRFLOW-2770] kubernetes: add support for
dag folder in the docker i…
URL:
https://github.com/apache/incubator-airflow/pull/3683#issuecomment-447053900
@ashb @dimberman revert branch is
created(https://github.com/apache/incubator-airflow/pull/4318).
feng-tao commented on issue #4318: Revert [AIRFLOW-2770] [AIRFLOW-3505]
URL:
https://github.com/apache/incubator-airflow/pull/4318#issuecomment-447053612
PTAL @dimberman @ashb
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/AIRFLOW-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720426#comment-16720426
]
ASF GitHub Bot commented on AIRFLOW-2770:
-
feng-tao opened a new pull request #4318: Revert
feng-tao opened a new pull request #4318: Revert [AIRFLOW-2770] [AIRFLOW-3505]
URL: https://github.com/apache/incubator-airflow/pull/4318
The k8s CI seems to be broken after
https://github.com/apache/incubator-airflow/pull/3683 is merged(although local
pr test if pass. suspect the pr
[
https://issues.apache.org/jira/browse/AIRFLOW-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tao Feng closed AIRFLOW-1919.
-
> Add option to query for DAG runs given a DAG ID
> ---
>
>
[
https://issues.apache.org/jira/browse/AIRFLOW-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720421#comment-16720421
]
Tao Feng commented on AIRFLOW-1919:
---
[~villasv] , the code has been checked in.
> Add option to
[
https://issues.apache.org/jira/browse/AIRFLOW-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720414#comment-16720414
]
ASF GitHub Bot commented on AIRFLOW-3501:
-
kppullin closed pull request #4307: [AIRFLOW-3501]
kppullin closed pull request #4307: [AIRFLOW-3501] k8s executor - Support
loading dags from image.
URL: https://github.com/apache/incubator-airflow/pull/4307
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
kppullin commented on issue #4307: [AIRFLOW-3501] k8s executor - Support
loading dags from image.
URL:
https://github.com/apache/incubator-airflow/pull/4307#issuecomment-447049548
Yup, this is a dupe of 2270. I'll close this out and make a separate PR to
include the tests from this PR.
ashb commented on issue #4312: AIRFLOW-3508: add slugify env to build.sh script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-447042090
Something on master broke the Kube tests - we're working on fixing/reverting
that break.
But before that the Kube tests
kaxil removed a comment on issue #3880: [AIRFLOW-461] Support autodetected
schemas in BigQuery run_load
URL:
https://github.com/apache/incubator-airflow/pull/3880#issuecomment-447026406
@tiagovtr it has been added to the docstring
kaxil commented on issue #3880: [AIRFLOW-461] Support autodetected schemas in
BigQuery run_load
URL:
https://github.com/apache/incubator-airflow/pull/3880#issuecomment-447026406
@tiagovtr it has been added to the docstring
tiagovrtr commented on issue #3880: [AIRFLOW-461] Support autodetected schemas
in BigQuery run_load
URL:
https://github.com/apache/incubator-airflow/pull/3880#issuecomment-447025564
Great commit, thank you
Can you also please add the argument to the docstring?
eran-levy commented on issue #4312: AIRFLOW-3508: add slugify env to build.sh
script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-447024110
can we re-run the travis build as soon as cloudflare issues fixed? it seems
like build failed for all PRs
eran-levy commented on issue #4312: AIRFLOW-3508: add slugify env to build.sh
script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-447023278
@ashb
we need this change otherwise the build.sh fails - it executes the followig:
python setup.py sdist -q
and
[
https://issues.apache.org/jira/browse/AIRFLOW-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720335#comment-16720335
]
Victor Villas Bôas Chaves commented on AIRFLOW-1919:
[~kaxilnaik]
AFAICS this is
ashb commented on issue #4312: AIRFLOW-3508: add slugify env to build.sh script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-447018890
What is this change needed for? Travis already sets that env var globally
ashb commented on issue #3683: [AIRFLOW-2770] kubernetes: add support for dag
folder in the docker i…
URL:
https://github.com/apache/incubator-airflow/pull/3683#issuecomment-447017461
I'd like it if we reverted this before the weekend - it's not great to see
tests failing on other PRs
stale[bot] commented on issue #4050: [AIRFLOW-3178] Don't bake ENV and _cmd
into tmp config for non-sudo
URL:
https://github.com/apache/incubator-airflow/pull/4050#issuecomment-446998066
This issue has been automatically marked as stale because it has not had
recent activity. It will be
stale[bot] commented on issue #4003: [AIRFLOW-3163] add operator to enable
setting table description in BigQuery table
URL:
https://github.com/apache/incubator-airflow/pull/4003#issuecomment-446998073
This issue has been automatically marked as stale because it has not had
recent
[
https://issues.apache.org/jira/browse/AIRFLOW-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor resolved AIRFLOW-3176.
Resolution: Duplicate
> Duration tooltip on Tree View of Tasks
>
eladkal commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks
to hive_hook everywhere
URL:
https://github.com/apache/incubator-airflow/pull/4317#issuecomment-446987017
@ashb done.
This is an automated
[
https://issues.apache.org/jira/browse/AIRFLOW-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720211#comment-16720211
]
Sai Phanindhra commented on AIRFLOW-3223:
-
[~ashb] I think airflow already supports github
[
https://issues.apache.org/jira/browse/AIRFLOW-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Brockmeier reassigned AIRFLOW-1552:
--
Assignee: Thomas Brockmeier
> Airflow Filter_by_owner not working with
[
https://issues.apache.org/jira/browse/AIRFLOW-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720179#comment-16720179
]
ASF GitHub Bot commented on AIRFLOW-766:
ashb closed pull request #2209: [AIRFLOW-766] Skip
ashb closed pull request #2209: [AIRFLOW-766] Skip conn.commit() when in
Auto-commit
URL: https://github.com/apache/incubator-airflow/pull/2209
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
ashb commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to
hive_hook everywhere
URL:
https://github.com/apache/incubator-airflow/pull/4317#issuecomment-446969682
Please add a mention of this in UPDATING.md
ashb commented on issue #4312: AIRFLOW-3508: add slugify env to build.sh script
URL:
https://github.com/apache/incubator-airflow/pull/4312#issuecomment-446969349
Test are failing cos Cloudflare are having issues :(
> ERROR: error pulling image configuration: Get
[
https://issues.apache.org/jira/browse/AIRFLOW-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720163#comment-16720163
]
ASF GitHub Bot commented on AIRFLOW-2629:
-
eladkal opened a new pull request #4317:
eladkal opened a new pull request #4317: [AIRFLOW-2629] Change refrence of
hive_hooks to hive_hook everywhere
URL: https://github.com/apache/incubator-airflow/pull/4317
### Jira
- [ ] My PR addresses the following [Airflow
chhantyal commented on issue #4315: [AIRFLOW-1381] Specify host temporary
directory
URL:
https://github.com/apache/incubator-airflow/pull/4315#issuecomment-446965912
CI build failed but I think it's not related to this PR?
ashb commented on issue #4316: [AIRFLOW-3511] Create GCP Memorystore Redis Hook
URL:
https://github.com/apache/incubator-airflow/pull/4316#issuecomment-446956464
I'm not too familar with GCP, so this may not be a sensible question.
What is the use case here that you want to create
[
https://issues.apache.org/jira/browse/AIRFLOW-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720096#comment-16720096
]
ASF GitHub Bot commented on AIRFLOW-3511:
-
ryanyuan opened a new pull request #4316:
ryanyuan opened a new pull request #4316: [AIRFLOW-3511] Create GCP
Memorystore Redis Hook
URL: https://github.com/apache/incubator-airflow/pull/4316
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following
[
https://issues.apache.org/jira/browse/AIRFLOW-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720093#comment-16720093
]
ASF GitHub Bot commented on AIRFLOW-1381:
-
chhantyal opened a new pull request #4315:
chhantyal opened a new pull request #4315: [AIRFLOW-1381] Specify host
temporary directory
URL: https://github.com/apache/incubator-airflow/pull/4315
Allow user to specify temporary directory to use on the host machine;
default settings will cause an error on OS X due to the
stale[bot] commented on issue #3783: [AIRFLOW-2937] Support HTTPS in Http
connection form environment variables
URL:
https://github.com/apache/incubator-airflow/pull/3783#issuecomment-446943837
This issue has been automatically marked as stale because it has not had
recent activity. It
Ryan Yuan created AIRFLOW-3512:
--
Summary: Create GCP Memorystore Redis Operators
Key: AIRFLOW-3512
URL: https://issues.apache.org/jira/browse/AIRFLOW-3512
Project: Apache Airflow
Issue Type:
[
https://issues.apache.org/jira/browse/AIRFLOW-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on AIRFLOW-3512 started by Ryan Yuan.
--
> Create GCP Memorystore Redis Operators
> --
[
https://issues.apache.org/jira/browse/AIRFLOW-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Yuan updated AIRFLOW-3511:
---
Description: Add Google Cloud Memorystore hook to Airflow
[
https://issues.apache.org/jira/browse/AIRFLOW-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Yuan updated AIRFLOW-3511:
---
Summary: Create GCP Memorystore Redis Hook (was: Create GCP Memorystore
Redis Hook and Operators)
[
https://issues.apache.org/jira/browse/AIRFLOW-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on AIRFLOW-3511 started by Ryan Yuan.
--
> Create GCP Memorystore Redis Hook and Operators
>
[
https://issues.apache.org/jira/browse/AIRFLOW-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Yuan closed AIRFLOW-3433.
--
Resolution: Duplicate
> Create Google Cloud Spanner Hook
>
>
>
Ryan Yuan created AIRFLOW-3511:
--
Summary: Create GCP Memorystore Redis Hook and Operators
Key: AIRFLOW-3511
URL: https://issues.apache.org/jira/browse/AIRFLOW-3511
Project: Apache Airflow
Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720046#comment-16720046
]
ASF GitHub Bot commented on AIRFLOW-3398:
-
sprzedwojski opened a new pull request #4314:
sprzedwojski opened a new pull request #4314: [AIRFLOW-3398] Google Cloud
Spanner instance database query operator
URL: https://github.com/apache/incubator-airflow/pull/4314
### Jira
- [x] My PR addresses the following [Airflow
[
https://issues.apache.org/jira/browse/AIRFLOW-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor resolved AIRFLOW-3510.
Resolution: Duplicate
Duplicate of AIRFLOW-1381 which has an abandoned PR - if
Nar Kumar Chhantyal created AIRFLOW-3510:
Summary: DockerOperator on OSX: Mounts denied. The path
/var/folders/mk/xxx is not shared from OS X and is not known to Docker.\r\nYou
can configure shared paths from Docker -> Preferences... ->
gyamxxx opened a new pull request #4313: Update gcp_dataflow_hook.py
URL: https://github.com/apache/incubator-airflow/pull/4313
#1
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following
Tomoki Takahashi created AIRFLOW-3509:
-
Summary: add dataflow paramaters validation
Key: AIRFLOW-3509
URL: https://issues.apache.org/jira/browse/AIRFLOW-3509
Project: Apache Airflow
Bl3f removed a comment on issue #4084: [AIRFLOW-3205] Support multipart uploads
to GCS
URL:
https://github.com/apache/incubator-airflow/pull/4084#issuecomment-446894266
I'm sorry to ask but why don't you use the resumable param of the
`MediaFileUpload`? Actually the upload by chunks is
[
https://issues.apache.org/jira/browse/AIRFLOW-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720011#comment-16720011
]
Ash Berlin-Taylor commented on AIRFLOW-3223:
FAB uses Flask-OpenID for Oauth, and that
ashb commented on a change in pull request #2450: [Airflow-1413] Fix FTPSensor
failing on error message with unexpected text.
URL: https://github.com/apache/incubator-airflow/pull/2450#discussion_r241337462
##
File path: tests/contrib/sensors/test_ftp_sensor.py
##
@@
MarcusSorealheis commented on issue #4295: AIRFLOW-3452 removed an
unused/dangerous display-none
URL:
https://github.com/apache/incubator-airflow/pull/4295#issuecomment-446905720
this is ready to go. solves a simple problem.
MarcusSorealheis removed a comment on issue #4295: AIRFLOW-3452 removed an
unused/dangerous display-none
URL:
https://github.com/apache/incubator-airflow/pull/4295#issuecomment-446905720
this is ready to go. solves a simple problem.
Fokko commented on issue #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility
to Airflow
URL:
https://github.com/apache/incubator-airflow/pull/4068#issuecomment-446896104
Any time @oelesinsc24. Let me know when you're ready, so we can get this in!
Bl3f edited a comment on issue #4084: [AIRFLOW-3205] Support multipart uploads
to GCS
URL:
https://github.com/apache/incubator-airflow/pull/4084#issuecomment-446894266
I'm sorry to ask but why don't you use the resumable param of the
`MediaFileUpload`? Actually the upload by chunks is
Bl3f commented on issue #4084: [AIRFLOW-3205] Support multipart uploads to GCS
URL:
https://github.com/apache/incubator-airflow/pull/4084#issuecomment-446894266
I'm sorry to ask but why don't you use the resumable param of the
`MediaFileUpload`? Actually the upload by chunks is already
Fokko commented on issue #4283: [AIRFLOW-3450] Remove unnecessary sigint handler
URL:
https://github.com/apache/incubator-airflow/pull/4283#issuecomment-446891697
@NielsZeilemaker My suggestion would be to keep the PR's nice and small, so
that might be something for you to pick up :-)
oelesinsc24 commented on issue #4068: [AIRFLOW-2310]: Add AWS Glue Job
Compatibility to Airflow
URL:
https://github.com/apache/incubator-airflow/pull/4068#issuecomment-446891406
> Do you ever do anything else than Submit the job and the immediately start
a sensor to poll for it?
NielsZeilemaker commented on issue #4283: [AIRFLOW-3450] Remove unnecessary
sigint handler
URL:
https://github.com/apache/incubator-airflow/pull/4283#issuecomment-446890350
If you're going to fix/mess with it, also have a look at this line:
[
https://issues.apache.org/jira/browse/AIRFLOW-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong resolved AIRFLOW-3216.
---
Resolution: Fixed
Fix Version/s: 2.0.0
> HiveServer2Hook need a password
Fokko commented on issue #4057: [AIRFLOW-3216] HiveServer2Hook need a password
with LDAP authentication
URL:
https://github.com/apache/incubator-airflow/pull/4057#issuecomment-446887716
Thanks @jongyoul
This is an
Fokko commented on a change in pull request #4298: [AIRFLOW-3478] Make sure
that the session is closed
URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r241308955
##
File path: airflow/bin/cli.py
##
@@ -456,14 +448,12 @@ def _run(args, dag, ti):
Fokko commented on issue #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility
to Airflow
URL:
https://github.com/apache/incubator-airflow/pull/4068#issuecomment-446880175
Like stated earlier. My preference would be to have the operator itself poll
for it. If you think about atomicity,
[
https://issues.apache.org/jira/browse/AIRFLOW-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719892#comment-16719892
]
ASF GitHub Bot commented on AIRFLOW-3450:
-
Fokko closed pull request #4283: [AIRFLOW-3450]
Fokko closed pull request #4283: [AIRFLOW-3450] Remove unnecessary sigint
handler
URL: https://github.com/apache/incubator-airflow/pull/4283
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
Fokko commented on issue #4283: [AIRFLOW-3450] Remove unnecessary sigint handler
URL:
https://github.com/apache/incubator-airflow/pull/4283#issuecomment-446878286
Very good point @NielsZeilemaker Thanks for the elaboration. Setting a flag
which will cause the scheduler to shutdown sounds
93 matches
Mail list logo