[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-28 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r237042420 ## File path: airflow/security/kerberos.py ## @@ -80,10 +82,8 @@ def pe

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-28 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r237042420 ## File path: airflow/security/kerberos.py ## @@ -80,10 +82,8 @@ def pe

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-28 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r237037414 ## File path: tests/security/test_kerberos.py ## @@ -32,13 +33,26 @@ de

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-28 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r237037414 ## File path: tests/security/test_kerberos.py ## @@ -32,13 +33,26 @@ de

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-27 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236793244 ## File path: airflow/security/kerberos.py ## @@ -80,7 +82,7 @@ def per

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-27 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236791874 ## File path: airflow/security/kerberos.py ## @@ -110,11 +112,11 @@ def

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236360636 ## File path: tests/security/test_kerberos.py ## @@ -32,13 +33,26 @@ de

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236356747 ## File path: airflow/security/kerberos.py ## @@ -27,19 +27,21 @@ log

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236358598 ## File path: airflow/security/kerberos.py ## @@ -80,7 +82,7 @@ def per

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236358998 ## File path: airflow/security/kerberos.py ## @@ -110,11 +112,11 @@ def

[GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236288683 ## File path: airflow/security/kerberos.py ## @@ -55,8 +57,8 @@ def ren