cbandy commented on a change in pull request #3770: [AIRFLOW-3281] Fix
Kubernetes operator with git-sync
URL: https://github.com/apache/incubator-airflow/pull/3770#discussion_r230925125
##########
File path: airflow/contrib/executors/kubernetes_executor.py
##########
@@ -197,10 +209,15 @@ def __init__(self):
self._validate()
def _validate(self):
- if not self.dags_volume_claim and (not self.git_repo or not
self.git_branch):
+ # TODO: use XOR for dags_volume_claim and git_dags_folder_mount_point
+ if not self.dags_volume_claim \
+ and (not self.git_repo or not self.git_branch
+ or not self.git_dags_folder_mount_point) \
+ and not self.dags_volume_host:
Review comment:
Can this condition look like the error message? e.g.
```python
if not self.dags_volume_claim \
and not self.dags_volume_host \
and not (self.git_repo and self.git_branch and
self.git_dags_folder_mount_point):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
