[GitHub] rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.

2018-12-07 Thread GitBox
rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API. URL: https://github.com/apache/incubator-airflow/pull/3546#issuecomment-445247874 > how aren't all the other RBAC tests failing They are. When I follow the instructions in CONTRIBUTING.md

[GitHub] rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.

2018-12-03 Thread GitBox
rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API. URL: https://github.com/apache/incubator-airflow/pull/3546#issuecomment-443736807 Still having some trouble with the test: ``` ==

[GitHub] rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.

2018-11-29 Thread GitBox
rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API. URL: https://github.com/apache/incubator-airflow/pull/3546#issuecomment-442988770 @xnuinside sorry for the delay, I've been slammed at work but I do intend to follow up. --

[GitHub] rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.

2018-10-12 Thread GitBox
rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API. URL: https://github.com/apache/incubator-airflow/pull/3546#issuecomment-429358961 Thanks for the comments! I addressed all of them in a separate commit for ease of review. I can squash before me

[GitHub] rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.

2018-10-12 Thread GitBox
rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API. URL: https://github.com/apache/incubator-airflow/pull/3546#issuecomment-429340391 That's a valid concern, but my concern is that it will be much worse if airflow has to return all the runs and f

[GitHub] rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.

2018-10-09 Thread GitBox
rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API. URL: https://github.com/apache/incubator-airflow/pull/3546#issuecomment-428252232 Anyone able to help me figure out why the test I added is failing? On my initial commit, I was getting `No row