[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-28 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r237049395 ## File path: airflow/security/kerberos.py ## @@ -80,10 +82,8 @@ d

[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-27 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236970400 ## File path: tests/security/test_kerberos.py ## @@ -32,13 +33,26

[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-27 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236967908 ## File path: airflow/security/kerberos.py ## @@ -80,7 +82,7 @@ de

[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236365655 ## File path: airflow/security/kerberos.py ## @@ -27,19 +27,21 @@

[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236365531 ## File path: airflow/security/kerberos.py ## @@ -80,7 +82,7 @@ de

[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236365027 ## File path: tests/security/test_kerberos.py ## @@ -32,13 +33,26

[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236364587 ## File path: airflow/security/kerberos.py ## @@ -110,11 +112,11 @

[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236334789 ## File path: airflow/security/kerberos.py ## @@ -55,8 +57,8 @@ de

[GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…

2018-11-26 Thread GitBox
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236334348 ## File path: airflow/security/kerberos.py ## @@ -55,8 +57,8 @@ de