[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-445644567 @ashb, ? :) This

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-440524068 @kaxil, @criccomini, @davydov, hi guys! maybe somebody else can also review this P

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439674546 @ashb, any concerns/decisions about PR? -

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439180998 @ashb, all tests are passed, need I to add more tests? ---

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439129336 @ashb the second question about args - yes, you can mix it and all work ok, if

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439128812 @ashb, I know about this feature, it works from env variable by default. We don't

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439116184 @ashb, all passed ---

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439114161 @ashb, test_get_conn (tests.contrib.hooks.test_redis_hook.TestRedisHook) ... passe

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439103191 @ashb , I added version pin, wait for Travis now -

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439081682 @ashb, maybe set up now dependency with https://www.python.org/dev/peps/pep-0440/#

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439073558 @ashb , can you look whats going on with Travis or ping somebody? One test fails o

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439018010 @ashb, sounds good, let's do it this way. I made changes and checked by hand, seem

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-439005571 @ashb to add changes what I describe upper with parse_known_args() - 5 min ) I can

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-438946284 @ashb, I check what need to do if we want to use a solution, so, need to modify th

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-437983020 @ashb, I understand about what you talk and it's good way, but, it will side all a

[GitHub] xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function

xnuinside commented on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-437628926 @ashb, please review -