[ 
https://issues.apache.org/jira/browse/AIRFLOW-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alberto Garcia-Raboso closed AIRFLOW-3440.
------------------------------------------
    Resolution: Invalid

The instance is created in a class method.

> Redundant LoggingMixin instance
> -------------------------------
>
>                 Key: AIRFLOW-3440
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3440
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: 1.9.0, 1.10.0, 1.10.1
>            Reporter: Alberto Garcia-Raboso
>            Assignee: Alberto Garcia-Raboso
>            Priority: Trivial
>
> The class {{airflow.hooks.base_hook.BaseHook}} inherits from 
> {{airflow.utils.log.logging_mixin.LoggingMixin}}, so logging can be done with 
> {{self.log}} inside of the former.
> However, a fresh instance of {{LoggingMixin}} is created on [line 82 of 
> {{airflow/hooks/base_hook.py}}|https://github.com/apache/incubator-airflow/blob/1.10.1/airflow/hooks/base_hook.py#L82],
>  inside {{BaseHook}}, for use in the following line, which is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to