[ 
https://issues.apache.org/jira/browse/AIRFLOW-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727764#comment-16727764
 ] 

ASF GitHub Bot commented on AIRFLOW-3560:
-----------------------------------------

kaxil commented on pull request #4363: [AIRFLOW-3560] Add WeekEnd & DayOfWeek 
Sensors
URL: https://github.com/apache/incubator-airflow/pull/4363
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3560
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   One of the use-cases we had is we wanted to run certain tasks only on 
Weekends or certain days of the weeks. Along the way, I have seen more people 
requiring the same.
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   * `DayOfWeekSensorTests`
   * `WeekEndSensorTests`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Sensor that polls until a day of the week
> ---------------------------------------------
>
>                 Key: AIRFLOW-3560
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3560
>             Project: Apache Airflow
>          Issue Type: New Feature
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Minor
>             Fix For: 1.10.2
>
>
> One of the use-case we have is we want to run certain tasks only on Weekends



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to