[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-ariatosca/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449922 --- Diff: aria/modeling/utils.py --- @@ -51,74 +53,95 @@ def service_template(self): return self.container.service_template

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449742 --- Diff: aria/modeling/utils.py --- @@ -52,84 +53,95 @@ def service_template(self): return self.container.service_template

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449679 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/functions.py --- @@ -69,7 +69,7 @@ def __evaluate__(self, container_holder):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449714 --- Diff: aria/orchestrator/workflow_runner.py --- @@ -136,10 +137,11 @@ def _validate_no_active_executions(self, execution): active_e

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449695 --- Diff: aria/orchestrator/workflows/events_logging.py --- @@ -35,20 +35,20 @@ def _get_task_name(task): @events.start_task_signal.conn

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449551 --- Diff: tests/orchestrator/test_workflow_runner.py --- @@ -259,8 +258,9 @@ def _setup_mock_workflow_in_service(request, inputs=None): w

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449568 --- Diff: aria/modeling/exceptions.py --- @@ -57,3 +57,9 @@ class UndeclaredParametersException(ParameterException): """ ARIA mod

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119447056 --- Diff: aria/modeling/utils.py --- @@ -51,74 +53,95 @@ def service_template(self): return self.container.service_template

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446847 --- Diff: tests/orchestrator/test_workflow_runner.py --- @@ -259,8 +258,9 @@ def _setup_mock_workflow_in_service(request, inputs=None):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446252 --- Diff: aria/modeling/exceptions.py --- @@ -57,3 +57,9 @@ class UndeclaredParametersException(ParameterException): """ ARIA mo

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446194 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/functions.py --- @@ -69,7 +69,7 @@ def __evaluate__(self, container_holder):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445992 --- Diff: aria/modeling/utils.py --- @@ -51,74 +53,95 @@ def service_template(self): return self.container.service_template

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445999 --- Diff: aria/orchestrator/workflows/events_logging.py --- @@ -35,20 +35,20 @@ def _get_task_name(task): @events.start_task_signal.con

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445955 --- Diff: aria/orchestrator/workflow_runner.py --- @@ -136,10 +137,11 @@ def _validate_no_active_executions(self, execution): active_

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445875 --- Diff: aria/orchestrator/execution_plugin/instantiation.py --- @@ -16,107 +16,132 @@ # TODO: this module will eventually be moved to a new

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445302 --- Diff: tests/orchestrator/test_workflow_runner.py --- @@ -259,8 +258,9 @@ def _setup_mock_workflow_in_service(request, inputs=None): w

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119444625 --- Diff: tests/resources/service-templates/tosca-simple-1.0/node-cellar/node-cellar.yaml --- @@ -309,7 +311,7 @@ policy_types: client

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119444608 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/__init__.py --- @@ -384,18 +387,37 @@ def create_operation_template_model(context,

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119442939 --- Diff: aria/modeling/utils.py --- @@ -52,84 +53,95 @@ def service_template(self): return self.container.service_template

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119443983 --- Diff: aria/modeling/exceptions.py --- @@ -22,9 +22,9 @@ class ModelingException(AriaException): """ -class InputsExcep

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119444005 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/parameters.py --- @@ -71,6 +72,7 @@ def get_assigned_and_defined_property_values(co

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119443130 --- Diff: aria/modeling/exceptions.py --- @@ -57,3 +57,9 @@ class UndeclaredParametersException(ParameterException): """ ARIA mod

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119427199 --- Diff: aria/orchestrator/workflow_runner.py --- @@ -136,10 +137,11 @@ def _validate_no_active_executions(self, execution): active_e

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119428842 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/functions.py --- @@ -69,7 +69,7 @@ def __evaluate__(self, container_holder):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119428083 --- Diff: aria/orchestrator/workflows/events_logging.py --- @@ -35,20 +35,20 @@ def _get_task_name(task): @events.start_task_signal.conn

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119443917 --- Diff: aria/orchestrator/execution_plugin/instantiation.py --- @@ -16,107 +16,132 @@ # TODO: this module will eventually be moved to a new