[asterixdb] branch master updated: [NO ISSUE] Factor out date formatting

[tillw]

This is an automated email from the ASF dual-hosted git repository.

tillw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 2f68d4b  [NO ISSUE] Factor out date formatting
2f68d4b is described below

commit 2f68d4b685947a1746073738fa6955b34c951952
Author: Till Westmann <t...@couchbase.com>
AuthorDate: Sun Feb 3 08:56:01 2019 -0800

    [NO ISSUE] Factor out date formatting
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Change-Id: Id0b723865141bb7eecf87830537d8310bfe2a5d3
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/3144
    Sonar-Qube: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
    Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
    Contrib: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
    Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Murtadha Hubail <mhub...@apache.org>
---
 .../java/org/apache/asterix/om/base/ADateTime.java     | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
index 62e5c87..df38d1c 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
@@ -106,24 +106,18 @@ public class ADateTime implements IAObject {
 
     @Override
     public String toString() {
-        StringBuilder sbder = new StringBuilder();
-        sbder.append("datetime: { ");
-        try {
-            
GregorianCalendarSystem.getInstance().getExtendStringRepUntilField(chrononTime, 
0, sbder,
-                    GregorianCalendarSystem.Fields.YEAR, 
GregorianCalendarSystem.Fields.MILLISECOND, true);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
-        }
-        sbder.append(" }");
-        return sbder.toString();
+        return appendDatetime(new StringBuilder().append("datetime: { "), 
chrononTime).append(" }").toString();
     }
 
     public String toSimpleString() {
-        StringBuilder sbder = new StringBuilder();
+        return appendDatetime(new StringBuilder(), chrononTime).toString();
+    }
+
+    private static StringBuilder appendDatetime(StringBuilder sbder, long 
chrononTime) {
         try {
             
GregorianCalendarSystem.getInstance().getExtendStringRepUntilField(chrononTime, 
0, sbder,
                     GregorianCalendarSystem.Fields.YEAR, 
GregorianCalendarSystem.Fields.MILLISECOND, true);
-            return sbder.toString();
+            return sbder;
         } catch (IOException e) {
             throw new IllegalStateException(e);
         }